-
Notifications
You must be signed in to change notification settings - Fork 180
small tweaks to bump build v2.6.8 #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughSynchronized trackEvent in the mobile SDK client from async Promise to sync void using internal _adapters.analytics; removed Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor App
participant Client as MobileSDKClient
participant Analytics as AnalyticsAdapter
rect rgb(235,245,255)
note over App,Client: Previous (async) flow
App->>Client: trackEvent(event, payload)
alt adapters.analytics available
Client->>Analytics: trackEvent(event, payload)
Analytics-->>Client: Promise resolved
Client-->>App: Promise<void> (awaitable)
else missing adapter
Client-->>App: Promise<void> (early return)
end
end
Note over App,Client: ———
rect rgb(240,255,240)
note over App,Client: New (sync) flow
App->>Client: trackEvent(event, payload)
alt _adapters.analytics present
Client->>Analytics: trackEvent(event, payload) %% not awaited
Client-->>App: void (non-async)
else missing adapter
Client-->>App: void (no-op)
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/mobile-e2e.yml (2)
236-239: Direct cache usage violates coding guidelines.This workflow uses
actions/cache@v4directly instead of the shared composite caching actions from.github/actions/. Per the coding guidelines, caching should use the shared composite actions (likecache-yarn,cache-gradle,cache-pods) for consistency across workflows.As per coding guidelines.
Consider creating a shared composite action for Maestro caching (e.g.,
.github/actions/cache-maestro) and using it here instead of callingactions/cachedirectly.
282-288: Direct cache usage violates coding guidelines.This DerivedData cache uses
actions/cache@v4directly instead of a shared composite caching action. Per the coding guidelines, all caching should use shared composite actions from.github/actions/to maintain consistency and allow centralized cache key management.As per coding guidelines.
Consider creating a shared composite action for DerivedData caching (e.g.,
.github/actions/cache-derived-data) that accepts parameters for path, Xcode version, and lock file hashes.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/mobile-e2e.yml(1 hunks).github/workflows/mobile-sdk-demo-ci.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/**/*.{yml,yaml}
📄 CodeRabbit inference engine (AGENTS.md)
.github/workflows/**/*.{yml,yaml}: In GitHub Actions workflows, use shared composite caching actions from .github/actions (cache-yarn, cache-bundler, cache-gradle, cache-pods)
Do not call actions/cache directly; rely on the shared composite caching actions
When using cache actions, optionally pass cache-version (often with GH_CACHE_VERSION and tool version) for stable keys
Files:
.github/workflows/mobile-e2e.yml.github/workflows/mobile-sdk-demo-ci.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-deps
- GitHub Check: android-build-test
- GitHub Check: e2e-ios
- GitHub Check: analyze-ios
- GitHub Check: analyze-android
🔇 Additional comments (2)
.github/workflows/mobile-sdk-demo-ci.yml (1)
6-6: LGTM! Path trigger correctly includes mobile-sdk-alpha.The addition of
packages/mobile-sdk-alpha/**to the workflow triggers ensures that changes to the new alpha SDK package will properly trigger CI builds for the demo app..github/workflows/mobile-e2e.yml (1)
27-27: LGTM! Path trigger correctly includes mobile-sdk-alpha.The addition of
packages/mobile-sdk-alpha/**to the workflow triggers ensures that changes to the new alpha SDK package will properly trigger end-to-end tests, maintaining consistency with the demo CI workflow.
Summary by CodeRabbit
Refactor
Chores