Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop region parameterisation #363

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Drop region parameterisation #363

merged 2 commits into from
Feb 23, 2021

Conversation

72636c
Copy link
Member

@72636c 72636c commented Feb 22, 2021

🙊

@72636c 72636c requested a review from a team as a code owner February 22, 2021 13:02
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2021

🦋 Changeset detected

Latest commit: f817a43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for simplification? Would non-Sydney and multi-region services be expected to re-add what they need?

There will be fewer of those than we thought but there are also already Skuba services in SEEK Asia. I want to make sure we’re not being too aggressive here.

@72636c
Copy link
Member Author

72636c commented Feb 22, 2021

@etaoins yep it's purely simplification for newly initialised repos going forwards, and it would need to be re-added for a new multi-region service.

Granted this is upstreamed from a much-simplified template I'm building for the grad bootcamp, so maybe it's too aggressive.

Copy link

@tobyhei tobyhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any newly minted tech guidance written down about the default region we could link to yet?

@etaoins
Copy link
Contributor

etaoins commented Feb 22, 2021

@tobyhei

All the recent changes are reflected only in Confluence so far. There’s plans to merge things in to Tech Strategy once we have a better handle on what it should be.

For now ap-southeast-2 is a safe bet, though.

@72636c
Copy link
Member Author

72636c commented Feb 23, 2021

Also note that the only tangible difference here is that a newly initialised service will not log its region. That feels like a reasonable default and saves some $$$ since most of our services are not multi-region.

@72636c 72636c merged commit fc4096c into master Feb 23, 2021
@72636c 72636c deleted the hardcode-region branch February 23, 2021 02:01
72636c added a commit that referenced this pull request Feb 27, 2021
This was superseded by #363.
@72636c 72636c mentioned this pull request Feb 27, 2021
72636c added a commit that referenced this pull request Feb 27, 2021
This was superseded by #363.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants