-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop region parameterisation #363
Conversation
🦋 Changeset detectedLatest commit: f817a43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just for simplification? Would non-Sydney and multi-region services be expected to re-add what they need?
There will be fewer of those than we thought but there are also already Skuba services in SEEK Asia. I want to make sure we’re not being too aggressive here.
@etaoins yep it's purely simplification for newly initialised repos going forwards, and it would need to be re-added for a new multi-region service. Granted this is upstreamed from a much-simplified template I'm building for the grad bootcamp, so maybe it's too aggressive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any newly minted tech guidance written down about the default region we could link to yet?
All the recent changes are reflected only in Confluence so far. There’s plans to merge things in to Tech Strategy once we have a better handle on what it should be. For now |
Also note that the only tangible difference here is that a newly initialised service will not log its |
🙊