Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire REGION in favour of AWS_REGION #356

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Retire REGION in favour of AWS_REGION #356

merged 3 commits into from
Feb 15, 2021

Conversation

dan753722
Copy link
Contributor

Why:

  1. AWS_REGION is the reserved runtime environment variable in AWS lambda.
  2. AWS_SDK looks for AWS_REGION by default
  3. one less environment configuration in serverless.yml

References:
https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/setting-region.html#setting-region-environment-variable
https://docs.aws.amazon.com/lambda/latest/dg/configuration-envvars.html

@dan753722 dan753722 requested a review from 72636c February 15, 2021 03:42
@dan753722 dan753722 requested a review from a team as a code owner February 15, 2021 03:42
@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2021

🦋 Changeset detected

Latest commit: 271752f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@72636c 72636c enabled auto-merge (squash) February 15, 2021 03:47
@72636c 72636c merged commit 18aa0d7 into master Feb 15, 2021
@72636c 72636c deleted the retire-REGION-lambda branch February 15, 2021 03:50
72636c added a commit that referenced this pull request Feb 27, 2021
This was superseded by #363.
72636c added a commit that referenced this pull request Feb 27, 2021
This was superseded by #363.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants