Repository navigation
Follow-up residuals: Codex normal tier by default (user 13:22Z), #713/#726 gate-read P2s, #713's macOS-only fixes - #752
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32e6b0bde1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…726 gate-read P2s, and #713's macOS-only failures - Codex: the new-WSL additions set service_tier = "default" (standard), per the user's "Normal, fast on demand (Recommended)" at 2026-10-05T13:22:24Z; cited at openai/codex rust-v0.160.0; dated amendment in the changelog-parity record (and "their yes"). - #726 residuals: the repair-round-3 authorization table regenerated from --check --markdown (16 rows); find-skills' pinned Listing row matches the manifest (on, Codex yes). - #713 residuals: the research-harnesses owner note names round 4's compatibility amendments; the ntfy.sh/Telegram 'alert text leaves the host' note in the plan README and row. - #713 macOS-only failures (CI 37320629278): the chrome acceptance test stubs the WSL-only dpkg comparator with exact arguments; the Harbor guard uses the Bash 3.2-portable ${VAR+x} test instead of [[ -v ]] (main's bootstrap-macos.sh precedent). Built by a GPT-6.1 Sol worker (job-080); reviewed by the coordinator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…: registry last) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
32e6b0b to
3bbcc78
Compare
…egistry plus the owned rows) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude session native-agent-stack-5f: landing at head Observed main Required checks at this head: 7 pass . Unresolved review threads: 0. |
|
Claude session native-agent-stack-5f: post-merge observation. Landed as |
Scope
An upgraded Codex home kept the previous managed
service_tier = "fast"despite the selected normal default. F9 now migrates that one declared value through the native config writer, verifies readback and records completion so later/fastchoices survive. Round 3 also completes adoption for preserved tiers such asflex, and handles marker-only completion without a config write, process check or backup.ecfa112764c664d35377dd66b8cfcb67e5a94d60; lane:lane:foundation.3c779ea2f97d9cc1b437c0385c53fff5887a8f13; Round 3 repairs:8c1cfd39dc7058464667d235e30019aa187883d3. Validated head:d2f6d8c3de42226cf37fea5b145bfae73f867482.fast; actual marker readback must matchplan.expected. Missing-writer dry-run refuses consistently with apply, and native local rejection diagnostics retain their text.SOTA sources
Handbook CI repair follows the maintained repository generator at
native-agent-stack@d2f6d8c3de42226cf37fea5b145bfae73f867482:scripts/build_new_wsl_handbook.py:189-190,693,1196-1199,1209-1242, its existing freshness oracletests/test_new_wsl_handbook.py:1440-1457, and the exact native CI command.github/workflows/validate.yml:235-240.openai/codex@
a956835d020762cb2b570053af06f643a11c0ecc(rust-v0.160.0): service-tier persistence:105-122, native batch request:154-170, toggle:47-57, persistence event:99-117, event dispatch:2391-2396 and Fast aliases:547-551. These support completion for preserved tiers while retaining later native choices.Same pin: config-manager write response:426-438, canonical fingerprint:54-65, tier resolution:35-42 and model catalog:512. Native versions are configuration hashes; rollback hashes the same validated disk snapshot.
Reused native wrapper, native-agent-stack@
32e6b0bde15d82cfbcccb117af3a728c5e9eeb5d: AppServer:514-560, guarded transaction:1257-1273. No new scalar editor or RPC wrapper.Marker-only contract at native-agent-stack@
3bbcc780dfc34829219dff169b283f29a10845c1: Decision 11:210, running-process control:3599-3602, failed-pgrep control:3662-3668.Original residual sources: native-agent-stack@
2d849ba1fe1b879144cfa470f0514d3ac3b8e487,tools/adoption/new_wsl_client_config.py:1421-1446,adoption/skills/manifest.json:542-564,evidence/artifacts/final-architecture-round2-20261004/integration-resolutions.json:1614-1674andadoption/bootstrap-macos.sh; prometheus/alertmanager@v0.34.1, Telegram configuration; historical hosted-macOS run 37320629278, artifactfull-suite-macos.log:12587-12637.Evidence-class table
--checkandvalidate.py, exit 0; integrity onlyLocal commands run
The three requested checks were rerun on the committed head above. Heavy checks use
nice 19,PYTHONDONTWRITEBYTECODE=1and an owned external-cacheTMPDIR; private paths are omitted here. Generator outputs and whitespace checks are from the final commit preparation.The receipt retains earlier failures/results and Round 3's five failing controls followed by 16 passing focused checks and the full module. The original pre-migration 426-test run remains historical; it is not represented as rerun after these repairs. CI status is separate from local acceptance.
Validate repair (2026-10-06)
The required validate job at
d2f6d8c3de42226cf37fea5b145bfae73f867482failed its existing handbook freshness assertion. #752 added migration prose to the hashed distro guide without regenerating the two handbook artifacts. The recorded4e505c4e...digest matches main/baseecfa112...; the PR's input isf6401392.... This is #752 input drift, and OSV is a separate job.Regenerated through the unchanged repository builder and refreshed the handbook receipt's two output hashes, preserving its regeneration history. The generated MD and JSON diffs contain only that provenance digest. No generator, test, client template, migration logic or host configuration changed in this repair.
Source chain:
native-agent-stack@d2f6d8c3de42226cf37fea5b145bfae73f867482:scripts/build_new_wsl_handbook.py:189-190,693,1196-1199,1209-1242;tests/test_new_wsl_handbook.py:1440-1457;.github/workflows/validate.yml:235-240. Original failed CI job. Repair receipt:evidence/artifacts/codex-service-tier-migration-20261005/ci-validate-repair-20261006.json.The full local suite result is retained without calling it green: it lacks
exchange_calendars, and has additional native shell/fixture/containment/export/installed-client notification findings not present in CI's failure summary. Those are separate owner follow-ups; this repair disables no gate and installs nothing on the shared host. Local Python is 3.13.16; CI's declared interpreter is 3.12.3.The workflow's run block was executed unchanged at nice 19, with private external-cache RUNNER_TEMP/TMPDIR:
Final repair validation:
TMPDIR=<owned-cache> PYTHONDONTWRITEBYTECODE=1 rtk proxy nice -n 19 python3 scripts/validate.pyexit 0 (69 components, 10,275 hashed files, 4 profiles, 212 receipts);rtk git diff --checkexit 0. Component-matrix and grand-list regeneration both exit 0, unchanged, with zero status flips.Generated handbook/receipt and registry changes are in the last repair commit. New-head CI is observed after push; local green is not a predeclared GitHub acceptance result.
Decision record
Codex service-tier migration, including Round 3 marker policy and dated disposition follow-up; normal-default amendment. A later user policy choice or supported upstream migration facility would reopen the decision.
Host evidence
No new host receipt, native-writer execution, provider acceptance or platform-status promotion. The next approved F9 apply after landing rewrites an upgraded home's unmarked previous
fastvalue through a native app-server write, with backup and readback before marker completion. Marker-only adoption leaves config bytes intact. The configuration owner performs host application; this lane made no host configuration change.Recovery limits remain documented: separate config/marker writes, failed fresh adoption before a later
/fastchoice, canonical-version formatting limits and additional migration-rule recovery policy. The synthetic AppServer fixture does not establish native writer acceptance.Checklist
lane:foundationlabel; registry last; no merge or readiness toggle.