op calldataload (specs)#34
Closed
roynalnaruto wants to merge 6 commits into
Closed
Conversation
2 tasks
icemelon
force-pushed
the
feature/calldatacopy
branch
2 times, most recently
from
64a2ab7 to
780fdb3
Compare
* Add GASPRICE specs markdown file * Add GASPRICE spec impl * Add GASPRICE spec impl tests * Apply fmt
* impl calldatacopy spec * add docs * fix * lint * rebase and fix * address comments Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
- Update the state proof document
- Write the spec of the state circuit in python from scratch following
the current `rw_table` design.
- Add state circuit tests
- List of changes:
- Renamed key and aux columns so start with index 0, in order to
make it more readable when working with code were we have arrays
called `keys`. This way `key0` == `keys[0]`.
- Add a new key column so that we have a cloumn exclusive for
address keys, which allows us to reuse the key order constraints
for addresses for all operations.
- Add the boilerplate for the missing operations
- Remove value2 column (used for `valuePrev`) in some Write
operations
* init: increase RwTable size * fix test except begin_tx * fix test_ begin_tx * clean up * lint codes * fix call_context_lookup * fix stack_lookup * update * fix * fix * update * fix test_sload * t# This is a combination of 2 commits. fix test_sstore * rename * format .md * fix * better naming * fix * update markdown * update python * update markdown * update sload codes * update test_sload * update test_sstore * change lookup for CalleeAddress from TxContextLookup to CallContextLookup * Update tx refund (#36) * update markdown * update python * update test * format codes * improve * Fix to FQ (from int) as PR-109. * Fix to return FQ for some functions in `instruction.py`, and run `make fmt`. * remove "intrinsic gas" comments Co-authored-by: Han <tinghan0110@gmail.com> * update account_storage_read, use tx_id, enforce following stak_push * fix test_sload * move storage_gas to param.py * fix * update account_storage_write_with_reversion, use tx_id, constrain value equal * fix Co-authored-by: HAOYUatHZ <haoyu@protonmail.com> Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Co-authored-by: Steven Gu <asongala@163.com> Co-authored-by: Han <tinghan0110@gmail.com>
Member
|
could you rebase and send pr to upstream? |
roynalnaruto
force-pushed
the
feat/calldataload
branch
from
c72e6e6 to
50c241d
Compare
Author
|
Closing since PR has been filed to upstream: here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.