Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

add sload & sstore specs#106

Merged
ChihChengLiang merged 48 commits into
privacy-ethereum:masterfrom
scroll-tech:new_sload_sstore
Feb 23, 2022
Merged

add sload & sstore specs#106
ChihChengLiang merged 48 commits into
privacy-ethereum:masterfrom
scroll-tech:new_sload_sstore

Conversation

@scroll-dev
Copy link
Copy Markdown
Contributor

@scroll-dev scroll-dev commented Jan 26, 2022

@scroll-dev scroll-dev changed the title New sload sstore add sload & sstore specs Jan 26, 2022
@han0110 han0110 self-requested a review January 26, 2022 05:06
@0xmountaintop
Copy link
Copy Markdown
Contributor

0xmountaintop commented Jan 27, 2022

just realize that I forget to count call_context_lookup into rw_counter. will update accordingly.

0xmountaintop and others added 2 commits February 13, 2022 22:33
* update markdown

* update python

* update test
@0xmountaintop
Copy link
Copy Markdown
Contributor

conflict with current master.

Trying to resolve

Comment thread src/zkevm_specs/evm/execution/storage.py Outdated
Comment thread src/zkevm_specs/evm/execution/storage.py Outdated
Comment thread src/zkevm_specs/evm/execution/storage.py Outdated
Comment thread src/zkevm_specs/evm/execution/storage.py Outdated
Comment thread src/zkevm_specs/evm/execution/storage.py Outdated
Comment thread src/zkevm_specs/evm/execution/storage_gas.py Outdated
Copy link
Copy Markdown
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most part looks great! Thanks for handling such opcode with the msot complicated gas calculation.

Comment thread src/zkevm_specs/evm/instruction.py
Comment thread src/zkevm_specs/evm/instruction.py Outdated
Copy link
Copy Markdown
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants