This repository was archived by the owner on Jul 5, 2024. It is now read-only.
op CALLDATALOAD#129
Merged
Merged
Conversation
This was referenced Feb 24, 2022
Collaborator
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
First round of review
CPerezz
suggested changes
Mar 3, 2022
Contributor
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
Some questions related to the fields used in the opcode impl.
Not really sure the logic is correct. But happy to see an explanation as maybe I'm wrong or not getting it :)
ed255
reviewed
Mar 3, 2022
DreamWuGit
reviewed
Mar 7, 2022
DreamWuGit
reviewed
Mar 7, 2022
DreamWuGit
reviewed
Mar 7, 2022
DreamWuGit
reviewed
Mar 7, 2022
Collaborator
Author
|
@ChihChengLiang @ed255 @CPerezz would be great to have your reviews on the circuits PR privacy-ethereum/zkevm-circuits#346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circuits PR here