Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new Testnet Pop-Network #70

Merged
merged 4 commits into from
May 1, 2024
Merged

chore: add new Testnet Pop-Network #70

merged 4 commits into from
May 1, 2024

Conversation

peetzweg
Copy link
Collaborator

New pallet-contracts supporting testnet on the block.
Probably the replacement for rococo.contracts

https://popnetwork.xyz/

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 68e3c84

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@peetzweg peetzweg requested a review from wottpal April 26, 2024 11:51
src/chains.ts Outdated
network: 'pop-network',
name: 'Pop Network',
ss58Prefix: 42,
rpcUrls: ['wss://rpc1.paseo.popnetwork.xyz', 'wss://rpc2.paseo.popnetwork.xyz'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have launched an extra node 'wss://rpc3.paseo.popnetwork.xyz' :)

src/chains.ts Outdated
@@ -36,6 +36,18 @@ export const alephzeroTestnet: SubstrateChain = {
faucetUrls: ['https://faucet.test.azero.dev'],
}

export const popNetwork: SubstrateChain = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Pop Network" solely a testnet or will there be a mainnet endpoint at some point, too? If yes, I would suggest a naming convention like: popMainnet & popTestnet. Wdyt? cc @al3mart

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there already existed a naming convention for this relay/parachain scheme, but it think it would be worth coming up with a common scheme, than we it would be clear what the Pop Network mainnet and testnet would be depending on the relay chain.
Something like Paseo/PopNetwork, Polkadot/PopNetwork.

Thinking this even further it would be actually pretty cool imho to use some sort of defined standard for a simple string representation of full XCM multilocation for the chain. Than it would be more like a proper URI which can be used to create xcm destinations, cc @Daanvdplas.

https://paritytech.github.io/xcm-docs/fundamentals/multilocation/index.html

Copy link

@al3mart al3mart Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome @peetzweg. I guess something like the NetworkId would be useful for that

@wottpal this is pointing to the testnet, but it is meant to exist on Pokadot :) So making sure users can differentiate between both will be handy.

popNetwork and popTestnet might work perfectly fine! Though, if a common scheme is to be used we are more than happy to follow that. Personally, I like the idea of prepending the relay name to the parachain name, it reads very clear.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to popNetworkTestnet and pop-network-testnet for now. We might come up with a more general naming scheme for everything in the future but should for sure not be part of this pr. :)

export const popNetworkTestnet: SubstrateChain = {
network: 'pop-network-testnet',

@peetzweg peetzweg requested a review from wottpal April 30, 2024 13:41
@wottpal wottpal merged commit e16fa0f into main May 1, 2024
@wottpal wottpal deleted the pz-pop-network branch May 1, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants