Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add new Testnet Pop-Network #70

Merged
merged 4 commits into from
May 1, 2024
Merged

chore: add new Testnet Pop-Network #70

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aeee0e6
adds smart contract capable Pop Network
peetzweg Apr 26, 2024
31f6089
docs(changeset): aadds smart contract capable Pop Network to defined …
peetzweg Apr 26, 2024
bc60f40
adds testnet suffix for now
peetzweg Apr 30, 2024
68e3c84
feat: Add `popNetworkTestnet` to `allSubstrateChains`
wottpal May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-countries-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@scio-labs/use-inkathon": minor
---

aadds smart contract capable Pop Network to defined chains
12 changes: 12 additions & 0 deletions src/chains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ export const alephzeroTestnet: SubstrateChain = {
faucetUrls: ['https://faucet.test.azero.dev'],
}

export const popNetwork: SubstrateChain = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Pop Network" solely a testnet or will there be a mainnet endpoint at some point, too? If yes, I would suggest a naming convention like: popMainnet & popTestnet. Wdyt? cc @al3mart

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there already existed a naming convention for this relay/parachain scheme, but it think it would be worth coming up with a common scheme, than we it would be clear what the Pop Network mainnet and testnet would be depending on the relay chain.
Something like Paseo/PopNetwork, Polkadot/PopNetwork.

Thinking this even further it would be actually pretty cool imho to use some sort of defined standard for a simple string representation of full XCM multilocation for the chain. Than it would be more like a proper URI which can be used to create xcm destinations, cc @Daanvdplas.

https://paritytech.github.io/xcm-docs/fundamentals/multilocation/index.html

Copy link

@al3mart al3mart Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome @peetzweg. I guess something like the NetworkId would be useful for that

@wottpal this is pointing to the testnet, but it is meant to exist on Pokadot :) So making sure users can differentiate between both will be handy.

popNetwork and popTestnet might work perfectly fine! Though, if a common scheme is to be used we are more than happy to follow that. Personally, I like the idea of prepending the relay name to the parachain name, it reads very clear.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to popNetworkTestnet and pop-network-testnet for now. We might come up with a more general naming scheme for everything in the future but should for sure not be part of this pr. :)

use-inkathon/src/chains.ts

Lines 39 to 40 in bc60f40

export const popNetworkTestnet: SubstrateChain = {
network: 'pop-network-testnet',

network: 'pop-network',
name: 'Pop Network',
ss58Prefix: 42,
rpcUrls: ['wss://rpc1.paseo.popnetwork.xyz', 'wss://rpc2.paseo.popnetwork.xyz'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have launched an extra node 'wss://rpc3.paseo.popnetwork.xyz' :)

explorerUrls: {
[SubstrateExplorer.PolkadotJs]: `https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc1.paseo.popnetwork.xyz`,
},
testnet: true,
faucetUrls: ['https://faucet.polkadot.io/'],
}

export const contracts: SubstrateChain = {
network: 'contracts',
name: 'Contracts on Rococo',
Expand Down