Feat: usePSP22Balances ignores active chain #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca9ce54 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ical10
force-pushed
the
feat/42-usePSP22Balances-ignores-active-chain
branch
from
a717d90
to
c4caf85
Compare
wottpal
force-pushed
the
feat/42-usePSP22Balances-ignores-active-chain
branch
from
d0c9881
to
25883e8
Compare
wottpal
requested changes
Nov 14, 2023
src/helpers/getPSP22Balances.ts
Outdated
| let balance = new BN(0) | ||
|
|
||
| const contract = psp22ContractMap[slug] | ||
| const _balanceOf = await contract.query['psp22::balanceOf']( |
There was a problem hiding this comment.
When testing getPSP22Balance (without hook) it throws:
TypeError: Cannot read properties of undefined (reading 'query')
I expect this happens here because it seems you never initialized the ContractPromise's. Or do I miss something?
src/helpers/getPSP22Balances.ts
Outdated
| let balance = new BN(0) | ||
|
|
||
| const contract = psp22ContractMap[slug] | ||
| const _balanceOf = await contract.query['psp22::balanceOf']( |
There was a problem hiding this comment.
Why are you not using our contractQuery helper?
There was a problem hiding this comment.
Replaced contract.query with contractQuery helper.
src/helpers/getPSP22Balances.ts
Outdated
| let balance = new BN(0) | ||
|
|
||
| const contract = psp22ContractMap[slug] | ||
| const _balanceOf = await contract.query['psp22::balanceOf']( |
There was a problem hiding this comment.
Why are you not using our contractQuery helper?
…activeChain` before fetching PSP22 tokens balance. - Improve formats and add INW testnet contract address on `PSP22_ASSETS.json`.
…pplicable for the active chain.
… `contractQuery`
ical10
force-pushed
the
feat/42-usePSP22Balances-ignores-active-chain
branch
from
493022d
to
f1a00ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42