Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usePSP22Balances ignores active chain #42

Closed
wottpal opened this issue Oct 31, 2023 · 0 comments · Fixed by #47
Closed

usePSP22Balances ignores active chain #42

wottpal opened this issue Oct 31, 2023 · 0 comments · Fixed by #47
Assignees
@ical10
Labels
bug Something isn't working

Comments

@wottpal
Copy link
Member

wottpal commented Oct 31, 2023

The current behavior is that all PSP22 balances are fetched, totally ignoring the active chain the user is on. Only PSP22s should be fetched where the originChain attribute matches the activeChain.network.

This would have not been an issue with a solution where I actively pass the tokens I want to fetch, but as discussed, for simplicity we stick to the current approach.
@wottpal wottpal added the bug Something isn't working label Oct 31, 2023
@ical10 ical10 mentioned this issue Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ical10 ical10

Labels
bug Something isn't working
Projects
ink!athon Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: usePSP22Balances ignores active chain scio-labs/use-inkathon
2 participants
@wottpal @ical10