Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #466 #471

Merged
merged 2 commits into from
Jun 5, 2021
Merged

Address #466 #471

merged 2 commits into from
Jun 5, 2021

Conversation

scenee
Copy link
Owner

@scenee scenee commented Jun 5, 2021

Fix a regression for the backdrop behavior reported on #466.

@scenee scenee changed the base branch from master to release/2.3.2 June 5, 2021 04:03
@scenee scenee changed the base branch from release/2.3.2 to master June 5, 2021 04:04
@scenee scenee merged commit 9c45c31 into master Jun 5, 2021
@scenee scenee deleted the iss-466 branch June 5, 2021 05:24
scenee added a commit that referenced this pull request Oct 13, 2022
This change is related to issue #466 and PR #471. But the issue doesn't
reproduce again after this commit.

And then the backdrop alpha update should be necessary for the change of
the view size or its size classes.

See #572 for more detail.
scenee added a commit that referenced this pull request Oct 13, 2022
This fixes #572. This backdrop alpha's update is appropriate for the change
of the view size or its size classes.

However this also affects issue #466 and PR #471 according to the comment.
But the issue doesn't reproduce again after this commit. And It's unlikely
that this change leads a regression of #466 on a modal presentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant