Fix the backdrop alpha issue (#572) #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #572. The main change is that `true` is passed as a `forceLayout` parameter into `viewWillTransition(to:with:)` callbacks. Because it's necessary for the backdrop alpha's update when the view size or its size classes changes. This also fixes a regression by 9c45c31. ```diff - layoutAdapter.activateLayout(for: state, forceLayout: true) + layoutAdapter.activateLayout(for: state, forceLayout: forceLayout) ``` The behavior before the above second change indicates that the method is working well even when `forceLayout` is set to `true` in their callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #572. The main change is that
trueis passed as aforceLayoutparameter intoviewWillTransition(to:with:)callbacks.Because it's necessary for the backdrop alpha's update when the view size or its size classes changes.
This also fixes a regression by 9c45c31.
The behavior before the above second change indicates that the method is working well even when
forceLayoutis set totruein their callbacks.