Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backdrop flickering after upgrading from 2.3.0 to 2.3.1 #466

Closed
sipersso opened this issue May 21, 2021 · 7 comments
Closed

Backdrop flickering after upgrading from 2.3.0 to 2.3.1 #466

sipersso opened this issue May 21, 2021 · 7 comments

Comments

@sipersso
Copy link

Please fill out this template appropriately when filing a bug report.

Please remove this line and everything above it before submitting.

Description

After upgrading from 2.3.0 to 2.3.1 there is a flickering effect when the backdrop is dimmed.

This is a video from 2.3.1
https://user-images.githubusercontent.com/6479433/119173355-7149ec80-ba67-11eb-8b95-50d31f4cd8a4.MP4

And this is how it looks after downgrading to 2.3.0

2.3.0_normal.MP4

Steps to reproduce

Code example that reproduces the issue

How do you display panel(s)?

I present it modally

How many panels do you displays?
1

Library version
2.3.1

Installation method
Swift Package Manager
@scenee
Copy link
Owner

scenee commented May 22, 2021 •
edited
Loading

Oh, i'm really sorry it's a regression in 2.3.1. Thanks for your quick report. I would like to fix this ASAP but I can't reproduce it. Could give more information(Device, Xcode and iOS versions etc) about your implementation, or give me a sample code to reproduce it?

@scenee
Copy link
Owner

scenee commented May 26, 2021

I might have found the cause of this issue. So I created a patch in iss-466 branch. It would be helpful if you could try the branch.

@sipersso
Copy link
Author

Thanks... Sorry for not being responsive and providing you with details. Have had a super busy week. Thanks for all the hard work you put into this.

@scenee
Copy link
Owner

scenee commented May 27, 2021

No problem, @sipersso :) I'm ok whenever you can.

@sipersso
Copy link
Author

sipersso commented Jun 2, 2021

Finally had a chance to try out the branch and can confirm that the iss-466 branch fixes the issue. Great job!

@scenee scenee mentioned this issue Jun 5, 2021
Merged
@scenee scenee closed this as completed in 9c45c31 Jun 5, 2021
@scenee
Copy link
Owner

scenee commented Jun 5, 2021

@sipersso Thank you so much! I've merged the patch into master. I will release v2.4.0 later.

@sipersso
Copy link
Author

sipersso commented Jun 6, 2021

Glad I could help! @scenee

scenee added a commit that referenced this issue Oct 13, 2022
@scenee
Change the backdrop alpha in a screen orientation.
fe46da6 
This change is related to issue #466 and PR #471. But the issue doesn't
reproduce again after this commit.

And then the backdrop alpha update should be necessary for the change of
the view size or its size classes.

See #572 for more detail.
scenee added a commit that referenced this issue Oct 13, 2022
@scenee
Change the backdrop alpha in a screen orientation.
85669db 
This fixes #572. This backdrop alpha's update is appropriate for the change
of the view size or its size classes.

However this also affects issue #466 and PR #471 according to the comment.
But the issue doesn't reproduce again after this commit. And It's unlikely
that this change leads a regression of #466 on a modal presentation.
@scenee scenee mentioned this issue Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scenee @sipersso