Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu for skeletons in 3d viewport #7809

Merged
merged 3 commits into from
May 21, 2024

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented May 16, 2024

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create a skeleton
  • rightclick a node in the 3d viewport
  • context menu should open

Issues:


(Please delete unneeded items, merge only when none are left open)

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fix works but I found another related bug 🙈 that completely crashes wk:

  1. open a new l4_sample hybrid annotation
  2. create a new volume layer
  3. active original segmentation layer & load a precomputed mesh
  4. activate the newly created volume layer
  5. in the 3d viewport open the context menu on the loaded precomputed mesh -> wk crashes completely 🙈

@philippotto
Copy link
Member Author

@MichaelBuessemeyer thanks for testing this! the bug you noticed is fixed in #7811 :)

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then lets mergy merge

@philippotto philippotto enabled auto-merge (squash) May 21, 2024 14:30
@philippotto philippotto merged commit 93258c2 into master May 21, 2024
2 checks passed
@philippotto philippotto deleted the fix-context-menu-for-skeletons-in-3d-viewport branch May 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants