Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu for skeletons in 3d viewport #7809

Merged
merged 3 commits into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed a bug where some annotation times would be shown double. [#7787](https://github.com/scalableminds/webknossos/pull/7787)
- Fixed a bug where no columns were shown in the time tracking overview. [#7803](https://github.com/scalableminds/webknossos/pull/7803)
- Fixed a bug where ad-hoc meshes for coarse magnifications would have gaps. [#7799](https://github.com/scalableminds/webknossos/pull/7799)
- Fixed that the context menu didn't open correctly in the 3D viewport when right-clicking a node. [#7809](https://github.com/scalableminds/webknossos/pull/7809)

### Removed

Expand Down
9 changes: 3 additions & 6 deletions frontend/javascripts/oxalis/controller/td_controller.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -254,18 +254,15 @@ class TDController extends React.PureComponent<Props> {
rightClick: (pos: Point2, plane: OrthoView, event: MouseEvent, isTouch: boolean) => {
if (this.props.planeView == null) return null;
const intersection = this.getMeshIntersection(pos);
if (intersection == null) {
return;
}
handleOpenContextMenu(
this.props.planeView,
pos,
plane,
isTouch,
event,
intersection.meshId,
intersection.meshClickedPosition,
intersection.unmappedSegmentId,
intersection?.meshId,
intersection?.meshClickedPosition,
intersection?.unmappedSegmentId,
);
},
};
Expand Down