Skip to content

Commit

Permalink
Fix context menu for skeletons in 3d viewport (#7809)
Browse files Browse the repository at this point in the history
* fix context menu for skeletons in 3d viewport

* update changelog
  • Loading branch information
philippotto authored May 21, 2024
1 parent 813003d commit 93258c2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed a bug where some annotation times would be shown double. [#7787](https://github.com/scalableminds/webknossos/pull/7787)
- Fixed a bug where no columns were shown in the time tracking overview. [#7803](https://github.com/scalableminds/webknossos/pull/7803)
- Fixed a bug where ad-hoc meshes for coarse magnifications would have gaps. [#7799](https://github.com/scalableminds/webknossos/pull/7799)
- Fixed that the context menu didn't open correctly in the 3D viewport when right-clicking a node. [#7809](https://github.com/scalableminds/webknossos/pull/7809)
- Fixed that right-clicking a mesh in the 3D viewport did crash when the corresponding segmentation layer was not visible. [#7811](https://github.com/scalableminds/webknossos/pull/7811)

### Removed
Expand Down
9 changes: 3 additions & 6 deletions frontend/javascripts/oxalis/controller/td_controller.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -254,18 +254,15 @@ class TDController extends React.PureComponent<Props> {
rightClick: (pos: Point2, plane: OrthoView, event: MouseEvent, isTouch: boolean) => {
if (this.props.planeView == null) return null;
const intersection = this.getMeshIntersection(pos);
if (intersection == null) {
return;
}
handleOpenContextMenu(
this.props.planeView,
pos,
plane,
isTouch,
event,
intersection.meshId,
intersection.meshClickedPosition,
intersection.unmappedSegmentId,
intersection?.meshId,
intersection?.meshClickedPosition,
intersection?.unmappedSegmentId,
);
},
};
Expand Down

0 comments on commit 93258c2

Please sign in to comment.