When merging volume tracings, also merge segment lists #6882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
changed the title
|
@frcroth I realize that this touches a lot of code that you are not yet familiar with. If you feel lost in the review, maybe we could go through the code together :) |
frcroth
approved these changes
Mar 2, 2023
| @@ -170,9 +170,9 @@ class VolumeTracingService @Inject()( | |||
| val resolutionSet = resolutionSetFromZipfile(dataZip) | |||
| if (resolutionSet.nonEmpty) resolutionSets.add(resolutionSet) | |||
| } | |||
| // if none of the tracings contained any volume data do not save buckets, use full resolution list | |||
| // if none of the tracings contained any volume data do not save buckets, use full resolution list, as alraedy initialized on wk-side | |||
There was a problem hiding this comment.
Suggested change
| // if none of the tracings contained any volume data do not save buckets, use full resolution list, as alraedy initialized on wk-side | |
| // if none of the tracings contained any volume data do not save buckets, use full resolution list, as already initialized on wk-side |
hotzenklotz
added a commit
that referenced
this pull request
Mar 6, 2023
…come_header_UI * 'master' of github.com:scalableminds/webknossos: (34 commits) Slim down view mode dropdown by using icons (#6900) Logging on password reset/change (#6901) When merging volume tracings, also merge segment lists (#6882) avoid spinner when switching tabs in dashboard (#6894) Upgrade Antd to v4.24 (#6865) Support n5 end-chunks with chunksize differing from metadata chunksize (#6890) Implement http range requests for HttpsSeekableByteChannel (#6869) new GH action for adding issues to project board Fix links in Changelog (#6881) adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879) Release 23.03.0 (#6880) Fix superUser being wrongly marked as organization owners (#6876) Followups for OME-TIFF export (#6874) Fix reload-precomputed-mesh functionality (#6875) Adds OME-TIFF export (#6838) Add evolutions 99,100 to migration guide (#6871) Add link to imprint and privacy to help menu (#6870) Annotation Locking Mechanism (#6819) Update deprecated antd <Menu> (#6860) Add functions to get and set segment colors to the frontend API (#6853) ...
hotzenklotz
added a commit
that referenced
this pull request
Mar 13, 2023
…pdown-menu * 'master' of github.com:scalableminds/webknossos: Avoid SQL error when fetching view config for zero-layer dataset (#6912) Fix date formatting for VX reports (#6908) Fix rare crash when viewing shared annotation (#6892) Slim down view mode dropdown by using icons (#6900) Logging on password reset/change (#6901) When merging volume tracings, also merge segment lists (#6882) avoid spinner when switching tabs in dashboard (#6894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging volume annotations, their segment lists are now also merged. This needs information from the actual data merging (now passed as MergedVolumeStats) because the segment ids are changed during the merge process.
The PR also adresses a bug where initialDataMultiple failed, because it tried looking up the resolution list from uploaded zipfiles, which failed due to a match error on path regex, and then it tried to look up the resolution list remotely, which failed because postgres does at that time not yet have an entry for the currently created annotation.
Also slipped in here, sorry for the small unrelated change: GlobalAccessContext in JobsController to yield a readable error message when a user tries to run a globalizeFloodfill job on a dataset of a different organization.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: