Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to imprint and privacy to help menu #6870

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

MichaelBuessemeyer
Copy link
Contributor

This pr adds a link to the imprint and privacy page to the help menu in the navbar.
It additionally might fix a potential bug where a new menu item added in #6819 did not get a key attribute. See here.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open any wk page
  • open the help menu and click on the two new links to imprint and privacy.
  • Those links should open a new tab with the respective wk.org page

Issues:


(Please delete unneeded items, merge only when none are left open)

  • [ ] Updated changelog
    • It is nothing really user-facing. Thus I would not add an entry for this.

- and add a key to the locked by user tag
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments before merging :)

frontend/javascripts/navbar.tsx Outdated Show resolved Hide resolved
frontend/javascripts/navbar.tsx Outdated Show resolved Hide resolved
link to local instance privacy and imprint page. not to wk.org

Co-authored-by: Philipp Otto <[email protected]>
@MichaelBuessemeyer MichaelBuessemeyer enabled auto-merge (squash) February 23, 2023 08:00
@MichaelBuessemeyer MichaelBuessemeyer merged commit cbbb045 into master Feb 23, 2023
@MichaelBuessemeyer MichaelBuessemeyer deleted the add-imprint branch February 23, 2023 08:18
hotzenklotz added a commit that referenced this pull request Mar 3, 2023
…d-v4.24

* 'master' of github.com:scalableminds/webknossos:
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
hotzenklotz added a commit that referenced this pull request Mar 6, 2023
…come_header_UI

* 'master' of github.com:scalableminds/webknossos: (34 commits)
  Slim down view mode dropdown by using icons (#6900)
  Logging on password reset/change (#6901)
  When merging volume tracings, also merge segment lists (#6882)
  avoid spinner when switching tabs in dashboard (#6894)
  Upgrade Antd to v4.24 (#6865)
  Support n5 end-chunks with chunksize differing from metadata chunksize (#6890)
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
  Update deprecated antd <Menu> (#6860)
  Add functions to get and set segment colors to the frontend API (#6853)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to imprint + privacy to every page
2 participants