Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followups for OME-TIFF export #6874

Merged
merged 7 commits into from
Feb 27, 2023
Merged

Followups for OME-TIFF export #6874

merged 7 commits into from
Feb 27, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Feb 24, 2023

URL of deployed dev instance (used for testing):

  • Fixes download filename
  • Fixes backend error when requesting larger bounding boxes (wasn't scaled by mag)

Steps to test:

  • Set a smaller exportTiffMaxVolumeMVx
  • Try to download some data of a large bbox (e.g. full layer) in a high mag
  • Should download the file with a proper filename: date__dataset__layer.ome.tiff

@normanrz normanrz self-assigned this Feb 24, 2023
@philippotto philippotto changed the title followups for OME-TIFF export Followups for OME-TIFF export Feb 24, 2023
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend lgtm 👍 Only tested the (named) download of annotations (without export) due to the dev instance not having a worker set up. I assume that you did test it locally.

frontend/javascripts/admin/admin_rest_api.ts Show resolved Hide resolved
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM :) I just added two small comments

app/models/job/Job.scala Outdated Show resolved Hide resolved
@bulldozer-boy bulldozer-boy bot merged commit dd15b20 into master Feb 27, 2023
@bulldozer-boy bulldozer-boy bot deleted the ome-tiff-followup branch February 27, 2023 10:40
hotzenklotz added a commit that referenced this pull request Mar 3, 2023
…d-v4.24

* 'master' of github.com:scalableminds/webknossos:
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
hotzenklotz added a commit that referenced this pull request Mar 6, 2023
…come_header_UI

* 'master' of github.com:scalableminds/webknossos: (34 commits)
  Slim down view mode dropdown by using icons (#6900)
  Logging on password reset/change (#6901)
  When merging volume tracings, also merge segment lists (#6882)
  avoid spinner when switching tabs in dashboard (#6894)
  Upgrade Antd to v4.24 (#6865)
  Support n5 end-chunks with chunksize differing from metadata chunksize (#6890)
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
  Update deprecated antd <Menu> (#6860)
  Add functions to get and set segment colors to the frontend API (#6853)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants