-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mag in data requests, no more zoomStep/exponent #6159
Conversation
@fm3 I'm not sure whether I got everything, but I switched the bucket request, the ad-hoc isosurface computation request, and the data cuboid request code. In my testing all of these work as expected, again. However, I'm not sure whether there's more interfaces that have changed. |
I also just noticed that the snapshot tests were not doing anything, because the snapshots were missed to move when the test directory was changed in #6065 /cc @philippotto. I corrected that, let's see whether any errors pop up. Edit: I added a82b6a1 so that this won't happen in the future. If a snapshot doesn't exist and the tests are run in a CI environment, the tests will fail. |
This reverts commit 1763f4f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, huge fan of the restructured datastore API ❤️
The backend changes look very good to me, props for using mags consistently, this helps readability in several places!
...-datastore/app/com/scalableminds/webknossos/datastore/controllers/BinaryDataController.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend part looks fine to me 👍 🔍 🚀
* | ||
* @ignore | ||
*/ | ||
_getDownloadUrlForRawDataCuboid( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring 👍
getHighestResolution(): Vector3 { | ||
// @ts-ignore | ||
return this.getResolutionByPowerOf2(this.getHighestResolutionPowerOf2()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that this method isn't used anywhere. Only getLowestResolution
is being used.
But I think it is fine to keep this method in case someone wants the highest resolution in the future.
URL of deployed dev instance (used for testing):
TODO
Follow-Up
Steps to test:
Issues: