Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Adapt to wk-datastore api version 2.0 (mag replaces zoomStep, thumbnail.jpg) #129

Merged
merged 1 commit into from
May 9, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 3, 2022

The webKnossos datastore API changes in scalableminds/webknossos#6159

  • thumbnail.json is removed (thus we implement thumbnail.jpg here now)
  • zoomStep is replaced by mag in data requests
  • bump api version to 2.0

I used Vec3D rather than Mag as it was the smaller change (and Mag is not hashable for caching). Note that in #117 we want to replace both by the Mag from wk-libs anyway.

Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@fm3 fm3 merged commit e209c9e into master May 9, 2022
@fm3 fm3 deleted the api-version-2 branch May 9, 2022 06:18
@fm3 fm3 changed the title Adapt to wk-datastore api version 2.0 (mag replaces zoomStep), thumbnail.jpg Adapt to wk-datastore api version 2.0 (mag replaces zoomStep, thumbnail.jpg) May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants