Compile tests to different dir to avoid unnecessary recompilations #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Feb 21, 2022
daniel-wer
added a commit
that referenced
this pull request
May 2, 2022
11 tasks
fm3
added a commit
that referenced
this pull request
May 9, 2022
* [WIP] use mag in data requests, no more zoomStep/exponent * unify mag parsing * some renaming from resolution to mag * some backwards compatibility * Fix types, remove dead code, clean up thumbnail creation * use 3-component mag instead of zoomstep when requesting buckets, isosurfaces and data cuboids * fix frontend tests * move test snapshots to new test directory, which was missed in #6065 * let tests fail in CI if a snapshot doesn't exist * test whether tests actually fail in CI if a snapshot is missing * pass through CI env variable to docker * Revert "test whether tests actually fail in CI if a snapshot is missing" This reverts commit 1763f4f. * update e2e snapshots * bump datastore api version * changelog + migration guide * drop swagger annotation Co-authored-by: Daniel Werner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
[info] Slick SQL schema already up to date.multiple times when I ranyarn test-prepare-watch(which meant that it recompiled).Issues:
(Please delete unneeded items, merge only when none are left open)