-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Project and TaskType names unique by Organization #5334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The front-end changes look very good 👍 Let's wait for the back-end review.
...javascripts/test/snapshots/public/test-bundle/test/backend-snapshot-tests/projects.e2e.js.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. See my minor question.
The other thing that should be checked is if we need all the indices in the db because AFAIK postgresql automatically creates indices for unique constraints, e.g. https://github.com/scalableminds/webknossos/blob/project-tasktype-unique-by-orga/tools/postgres/schema.sql#L432
Project and TaskType names had to be globally unique. Now, they are uniqe per organization.
TODO
URL of deployed dev instance (used for testing):
Steps to test:
Issues: