Skip to content

Revert "Make Project and TaskType names unique by Organization" #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

Revert "Make Project and TaskType names unique by Organization" #5379

merged 1 commit into from
Apr 8, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 8, 2021

Reverts #5334

Problem being that the new restriction of unique project names was too tight, deleted projects with duplicates existed in production. Thus, the db evolution did not succeed.

@fm3 fm3 requested a review from philippotto April 8, 2021 09:30
@fm3 fm3 self-assigned this Apr 8, 2021
@fm3 fm3 mentioned this pull request Apr 8, 2021
Closed
@fm3 fm3 enabled auto-merge (squash) April 8, 2021 09:53
philippotto
philippotto approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@fm3 fm3 merged commit 9f3b48c into master Apr 8, 2021
@fm3 fm3 deleted the revert-5334-project-tasktype-unique-by-orga branch April 8, 2021 11:26
fm3 added a commit that referenced this pull request Apr 8, 2021
@fm3
Revert "Revert "Make Project and TaskType names unique by Organization (
6d3d0ce 
#5334)" (#5379)"

This reverts commit 9f3b48c.
@fm3 fm3 mentioned this pull request Apr 8, 2021
Merged
16 tasks
fm3 added a commit that referenced this pull request Apr 15, 2021
@fm3
Make Project and TaskType names unique by Organization (second try) (#…
81bb40f 
…5381)

* Revert "Revert "Make Project and TaskType names unique by Organization (#5334)" (#5379)"

This reverts commit 9f3b48c.

* Enforce project name uniqueness only in scala

* fix sql comment syntax

* update sql reversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @philippotto