Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-Check that localstorage persistence typechecks work #5337

Open
fm3 opened this issue Mar 24, 2021 · 0 comments
Open

Double-Check that localstorage persistence typechecks work #5337

fm3 opened this issue Mar 24, 2021 · 0 comments
Labels
discussion frontend

Comments

@fm3
Copy link
Member

fm3 commented Mar 24, 2021

In persistence.js, we check PropTypes.checkPropTypes. When changing the type as part of #5334 we expected this check to fail, but it didn’t. Is there something wrong there?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fm3