Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable brush autofill when erasing #4729

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Disable brush autofill when erasing #4729

merged 2 commits into from
Jul 23, 2020

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jul 23, 2020 •
edited
Loading

This PR disables the autofill feature of the brush when using it to erase annotated data.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a volume tracing
  • Draw a big circle or so with the brush. The area within the brush should be automatically filled.
  • Use the brush to erase a bit of the outer border. Only the outer border should be erased and not the whole circle.

Issues:

@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Jul 23, 2020
@MichaelBuessemeyer MichaelBuessemeyer mentioned this pull request Jul 23, 2020
Closed
philippotto
philippotto approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MichaelBuessemeyer MichaelBuessemeyer merged commit fa8fc60 into master Jul 23, 2020
@philippotto philippotto deleted the disable-brush-autofill-when-erasing branch June 14, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@MichaelBuessemeyer MichaelBuessemeyer

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-filling can be problematic in brush/erase mode
2 participants
@MichaelBuessemeyer @philippotto