Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-filling can be problematic in brush/erase mode #4624

Closed
cnzqy1 opened this issue May 19, 2020 · 4 comments · Fixed by #4729
Closed

Auto-filling can be problematic in brush/erase mode #4624

cnzqy1 opened this issue May 19, 2020 · 4 comments · Fixed by #4729
Assignees
Labels

Comments

@cnzqy1
Copy link

cnzqy1 commented May 19, 2020

In brush mode, if I hold down the right mouse button and draw a full circle, the enclosed area is automatically erased (rather than just the outline). Is this the expected behavior? This is problematic since sometimes a cell is overfilled and I want to clean up the annotation by following along the membrane, but instead the whole cell is erased.

Maybe this is related to #3698? In that case filling should only happen in painting and not in erasing. Also, it would be helpful to expose a setting to toggle the fill function on/off since sometimes there are annular structures.

@philippotto
Copy link
Member

Thank you for opening this issue! Right now, this is indeed expected behavior, but your concerns make perfect sense. We will think about how to easily disable the "auto-fill" feature (maybe by default when erasing). We'll keep you up to date in this issue.

@philippotto philippotto changed the title Erasing behavior in brush mode Auto-filling can be undesired in brush/erase mode May 28, 2020
@philippotto philippotto changed the title Auto-filling can be undesired in brush/erase mode Auto-filling can be problematic in brush/erase mode May 28, 2020
@philippotto philippotto self-assigned this Jun 2, 2020
@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented Jul 23, 2020

@cnzqy1 We decided to add an option to turn off this auto-fill feature.

@MichaelBuessemeyer
Copy link
Contributor

We decided to add an option to turn off this auto-fill feature.

After another discussion we came to the conclusion to just disable the autofill feature when using the brush to erase annotated data. (#4729)

@cnzqy1
Copy link
Author

cnzqy1 commented Jul 23, 2020

We decided to add an option to turn off this auto-fill feature.

After another discussion we came to the conclusion to just disable the autofill feature when using the brush to erase annotated data. (#4729)

Thanks for the update! Yeah, I couldn't quite think of a use case where auto-fill is needed for erasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants