Disable brush autofill when erasing (#4729)

* disable brush autofill when erasing * update changelog
scalableminds · Jul 23, 2020 · fa8fc60 · fa8fc60
1 parent af257cd
commit fa8fc60
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -14,7 +14,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 -
 
 ### Changed
-- 
+- Disabled the autofill feature of the brush when using this tool to erase data. [#4729](https://github.com/scalableminds/webknossos/pull/4729)
 
 ### Fixed
 - 

diff --git a/frontend/javascripts/oxalis/model/sagas/volumetracing_saga.js b/frontend/javascripts/oxalis/model/sagas/volumetracing_saga.js
@@ -85,6 +85,9 @@ export function* editVolumeLayerAsync(): Generator<any, any, any> {
     const contourTracingMode = yield* select(
       state => enforceVolumeTracing(state.tracing).contourTracingMode,
     );
+    const isDrawing =
+      contourTracingMode === ContourModeEnum.DRAW_OVERWRITE ||
+      contourTracingMode === ContourModeEnum.DRAW;
 
     // Volume tracing for higher zoomsteps is currently not allowed
     if (yield* select(state => isVolumeTracingDisallowed(state))) {
@@ -118,7 +121,10 @@ export function* editVolumeLayerAsync(): Generator<any, any, any> {
         // if the current viewport does not match the initial viewport -> dont draw
         continue;
       }
-      if (activeTool === VolumeToolEnum.TRACE || activeTool === VolumeToolEnum.BRUSH) {
+      if (
+        activeTool === VolumeToolEnum.TRACE ||
+        (activeTool === VolumeToolEnum.BRUSH && isDrawing)
+      ) {
         currentLayer.addContour(addToLayerAction.position);
       }
       if (activeTool === VolumeToolEnum.BRUSH) {
-Original file line number
+Diff line change
@@ Expand Up @@
     -
     ### Changed
-    -
+    - Disabled the autofill feature of the brush when using this tool to erase data. [#4729](https://github.com/scalableminds/webknossos/pull/4729)
     ### Fixed
     -
@@ Expand Down @@