Always make wheel listeners not passive to allow preventDefault #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
reviewed
Mar 25, 2019
frontend/javascripts/libs/utils.js
Outdated
| @@ -436,6 +436,28 @@ export function isNoElementFocussed(): boolean { | |||
| return document.activeElement === document.body; | |||
| } | |||
|
|
|||
| const arePassiveEventsSupported = _.once(() => { | |||
There was a problem hiding this comment.
Maybe add that this is from https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Safely_detecting_option_support, in case we want to update or think about removing this code sometime in the future.
frontend/javascripts/libs/utils.js
Outdated
| element.addEventListener( | ||
| eventName, | ||
| wrapperFunc, | ||
| arePassiveEventsSupported() ? { passive: false } : false, |
There was a problem hiding this comment.
Now every event listener attached with addEventListenerWithDelegation is passive Edit: not passive, shouldn't we only do this for wheel events? I'd suggest adding another optional parameter options which is the same as the parameter to addEventListener. When attaching the wheel handler we can set passive to false there.
daniel-wer
changed the title
|
@daniel-wer Thanks for your feedback :) Done! If you approve, I'll merge this once the build succeeded. |
…/webknossos into fix-passive-wheel-listener
daniel-wer
approved these changes
Mar 25, 2019
philippotto
added a commit
that referenced
this pull request
Mar 25, 2019
* always make wheel listeners passive to allow preventDefault (fixes #3938) * update changelog * fix linting * fix missing function call * integrate pr feedback
hotzenklotz
added a commit
that referenced
this pull request
Mar 25, 2019
…ture-highlight * 'master' of github.com:scalableminds/webknossos: Hide unreported datasets (#3883) Update puppeteer and refresh screenshots (#3914) only show team names of own organization (#3928) Enable merger mode in skeleton and hybrid tracings (#3619) allow uploading nml for public dataset of different orga (#3929) Always make wheel listeners not passive to allow preventDefault (#3939) Enhance tree search functionallity (#3878) add webknossos-connect to setup (#3913) Update README.md (#3923) Add shortcut to maximize golden layout panes (#3927) Perform bucket picking in web workers and other performance optimizations (#3902) remove alt text for abstract brain loading image (#3930) updated documentation front page (#3917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: