Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puppeteer and refresh screenshots #3914

Merged
merged 16 commits into from
Mar 25, 2019
Merged

Update puppeteer and refresh screenshots #3914

merged 16 commits into from
Mar 25, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Mar 20, 2019 •
edited
Loading

  • updates puppeteer
  • updates screenshots
  • adds tolerance (0.1% of the screenshot may differ from the snapshot)
  • implements retry on a per-dataset-level

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • see build
  • Ready for review

@philippotto philippotto self-assigned this Mar 25, 2019
@philippotto philippotto marked this pull request as ready for review March 25, 2019 12:41
daniel-wer
daniel-wer approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good solution, thanks for your perseverance in fixing these 👍

@philippotto philippotto merged commit 57c7472 into master Mar 25, 2019
hotzenklotz added a commit that referenced this pull request Mar 25, 2019
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into fea…
5b3acc1 
…ture-highlight

* 'master' of github.com:scalableminds/webknossos:
  Hide unreported datasets (#3883)
  Update puppeteer and refresh screenshots (#3914)
  only show team names of own organization (#3928)
  Enable merger mode in skeleton and hybrid tracings (#3619)
  allow uploading nml for public dataset of different orga (#3929)
  Always make wheel listeners not passive to allow preventDefault (#3939)
  Enhance tree search functionallity (#3878)
  add webknossos-connect to setup (#3913)
  Update README.md (#3923)
  Add shortcut to maximize golden layout panes (#3927)
  Perform bucket picking in web workers and other performance optimizations (#3902)
  remove alt text for abstract brain loading image (#3930)
  updated documentation front page (#3917)
@normanrz normanrz deleted the fix-nightly branch August 12, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer