Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove alt text for abstract brain loading image #3930

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 20, 2019

This alt text kept flashing before the image was loaded. I’d argue that the image is only eye-candy and does not have to be replaced by an alt-text if it cannot be displayed.

  • Ready for review

@fm3 fm3 self-assigned this Mar 20, 2019
@fm3 fm3 requested a review from philippotto March 20, 2019 21:37
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I had that thought as well (even during development), but somehow forgot again about that (probably, because the alt-tag is only shown in firefox).

@philippotto philippotto merged commit ab2816f into master Mar 21, 2019
hotzenklotz added a commit that referenced this pull request Mar 25, 2019
…ture-highlight

* 'master' of github.com:scalableminds/webknossos:
  Hide unreported datasets (#3883)
  Update puppeteer and refresh screenshots (#3914)
  only show team names of own organization (#3928)
  Enable merger mode in skeleton and hybrid tracings (#3619)
  allow uploading nml for public dataset of different orga (#3929)
  Always make wheel listeners not passive to allow preventDefault (#3939)
  Enhance tree search functionallity (#3878)
  add webknossos-connect to setup (#3913)
  Update README.md (#3923)
  Add shortcut to maximize golden layout panes (#3927)
  Perform bucket picking in web workers and other performance optimizations (#3902)
  remove alt text for abstract brain loading image (#3930)
  updated documentation front page (#3917)
@normanrz normanrz deleted the spinner-no-alt-text branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants