Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve potentially misleading "NML upload" entry in version view #4883

Closed
daniel-wer opened this issue Oct 20, 2020 · 0 comments · Fixed by #5016
Closed

Improve potentially misleading "NML upload" entry in version view #4883

daniel-wer opened this issue Oct 20, 2020 · 0 comments · Fixed by #5016
Assignees
@philippotto
Labels
frontend low-hanging-fruit

Comments

@daniel-wer
Copy link
Member

The version view (Settings Dropdown - Restore older version) shows an entry like "Uploaded an NML with x nodes." when one update action batch contains more than one createNode update actions as that used to be the only action that could lead to this. However, in the mean time this could've also been caused by an Undo (for example, of the deletion of multiple trees) or Redo action. The error message should be generalized and say something like "Added x trees with y nodes." or so.

Todo in the code:

webknossos/frontend/javascripts/oxalis/view/version_entry.js

Line 160 in 43bb927

// TODO: This could've also been an undo/redo action.

@daniel-wer daniel-wer mentioned this issue Oct 20, 2020
Merged
7 tasks
@philippotto philippotto self-assigned this Dec 3, 2020
philippotto added a commit that referenced this issue Jan 4, 2021
@philippotto
don't assume NML import in version view when multiple nodes/trees wer…
8cb6c56 
…e added (undo/redo could also be responsible); fixes #4883
@philippotto philippotto mentioned this issue Jan 4, 2021
Merged
6 tasks
bulldozer-boy bot pushed a commit that referenced this issue Jan 5, 2021
@philippotto
Improve hint in version view (#5016)
e9b02ca 
* don't assume NML import in version view when multiple nodes/trees were added (undo/redo could also be responsible); fixes #4883
* adapt plural s and adapt icon
* format
* Merge branch 'master' into improve-hint-in-version-view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippotto philippotto

Labels
frontend low-hanging-fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve hint in version view scalableminds/webknossos
2 participants
@daniel-wer @philippotto