Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hint in version view #5016

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Improve hint in version view #5016

merged 4 commits into from
Jan 5, 2021

Conversation

philippotto
Copy link
Member

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I created a tree, deleted a tree and reverted that via undo
  • the version view looks like this:
    image

Issues:

@philippotto philippotto requested a review from daniel-wer January 4, 2021 15:45
@philippotto philippotto self-assigned this Jan 4, 2021
daniel-wer
daniel-wer approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@bulldozer-boy bulldozer-boy bot merged commit e9b02ca into master Jan 5, 2021
@bulldozer-boy bulldozer-boy bot deleted the improve-hint-in-version-view branch January 5, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve potentially misleading "NML upload" entry in version view
2 participants
@philippotto @daniel-wer