-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time-track movements in the 3D viewport #4876
Conversation
…dd many missing actions, improve save queue compaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff & clean up 👍 Worked well for me!
One thing I noticed during testing: Merely opening the version-restore-view seems to clear the undo stack. After opening and closing the version-restore-view, I cannot undo an action. But that's been like this probably before this PR? I cannot really see why this is happening. Maybe you know anything about this?
@@ -96,6 +157,7 @@ function getDescriptionForBatch(actions: Array<ServerUpdateAction>): Description | |||
|
|||
// If more than one createNode update actions are part of one batch, that is not a tree merge or split | |||
// an NML was uploaded. | |||
// TODO: This could've also been an undo/redo action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, tricky. A simple solution would be to generalize the description message (e.g., "X nodes were added.") or to just leave this as is. Figuring out what the correct reason is would obviously be better, but I can't think of a good solution right now :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we cannot do much about it easily apart from generalizing the message as you suggested. I'll create an issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference #4883
I'm afraid this is by design (so far). When a version is previewed (or the version view is closed) the tracing is restarted ( |
updateTdCamera
update action which is triggered if the user modified the 3D view, so that these actions can be time tracked. The action is empty otherwise.updateNode
update actions as otherwise lots of new versions are created if the radius of a node is changed or a node is moved.updateTdCamera
actions are also compacted and only the last one within one save interval is kept.TODO:
URL of deployed dev instance (used for testing):
Steps to test:
Issues: