fix: Use changed_at revision when updating fields#778
Merged
Veykril merged 1 commit intosalsa-rs:masterfrom Mar 25, 2025
Merged
fix: Use changed_at revision when updating fields#778Veykril merged 1 commit intosalsa-rs:masterfrom
changed_at revision when updating fields#778Veykril merged 1 commit intosalsa-rs:masterfrom
Conversation
Setting the field's revision to `current_revision` when updating is not technically wrong, but its pessimizing. If all previous reads only observed a change of up to `changed_at`, then it's fine for us to do the same as nothing we derive from has read from `current_revision`.
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #778 will not alter performanceComparing Summary
|
Member
Author
|
Looks like one of my parallel tests are flaky (note I don't think there is a bug in salsa, but a race in our testing signal infra) |
MichaReiser
approved these changes
Mar 25, 2025
MichaReiser
reviewed
Mar 25, 2025
Comment on lines
+571
to
572
| data.revisions = C::new_revisions(current_deps.changed_at); | ||
| data.created_at = current_revision; |
Contributor
There was a problem hiding this comment.
It might be a bit surprising that crated_at can now be larger than changed_at
Member
Author
There was a problem hiding this comment.
That is already the case when we allocate the struct
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the field's revision to
current_revisionwhen updating is not technically wrong, but its pessimizing. If all previous reads only observed a change of up tochanged_at, then it's fine for us to do the same as nothing we derive from has read fromcurrent_revision.