Skip to content

fix: Use changed_at revision when updating fields #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Veykril merged 1 commit into from
Mar 25, 2025
Merged

fix: Use changed_at revision when updating fields #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tracked_struct.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ where
// to meet its safety invariant.
unsafe {
if C::update_fields(
current_revision,
current_deps.changed_at,
&mut data.revisions,
self.to_self_ptr(std::ptr::addr_of_mut!(data.fields)),
fields,
Expand All @@ -568,7 +568,7 @@ where
}
}
if current_deps.durability < data.durability {
data.revisions = C::new_revisions(current_revision);
data.revisions = C::new_revisions(current_deps.changed_at);
data.created_at = current_revision;
Comment on lines +571 to 572
Copy link
Contributor

@MichaReiser MichaReiser Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a bit surprising that crated_at can now be larger than changed_at

Copy link
Member Author

@Veykril Veykril Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is already the case when we allocate the struct

}
data.durability = current_deps.durability;
Expand Down
Loading