-
-
Notifications
You must be signed in to change notification settings - Fork 600
Support of multiple zones for app_zoned_cleaning #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
168a169
Added new app_goto_target command
ciB89 9133209
added new command app_zoned_clean
ciB89 5b57e23
updated syntax with new commands
ciB89 a379648
removed whitespaces
ciB89 a3ef2f6
changed variable name for x_coord in zoned_clean
ciB89 52d1a52
Update test_vacuum.py
ciB89 bd96404
Update vacuum.py
ciB89 ef88a0c
Update test_vacuum.py
ciB89 f60ceb3
fixed typing error
ciB89 3c48e1c
WIP adding multiple zones for zoned_cleaning
ciB89 96c9500
added support for multiple zones
ciB89 a0f45dd
fixed syntax
ciB89 bb8c78c
updated description
ciB89 d4c5bf7
updated missing description
ciB89 8efc932
added feedback for new commands
ciB89 e84ae5b
updated syntax
ciB89 8b646f4
Use a list of zones instead of *args
syssi 8b30d2d
Clean-up
syssi b024c99
Fix legacy command line interface and docstrings
syssi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -197,6 +197,19 @@ def home(vac: miio.Vacuum): | |
| click.echo("Requesting return to home: %s" % vac.home()) | ||
|
|
||
|
|
||
| @cli.command() | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. expected 2 blank lines, found 1 |
||
| @pass_dev | ||
| def goto(vac: miio.Vacuum): | ||
| """Going to target.""" | ||
| click.echo("Going to target : %s" % vac.goto()) | ||
|
|
||
|
|
||
| @cli.command() | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. expected 2 blank lines, found 1 |
||
| @pass_dev | ||
| def zoned_clean(vac: miio.Vacuum): | ||
| """Cleaning zone(s).""" | ||
| click.echo("Cleaning zone(s) : %s" % vac.zoned_clean()) | ||
|
|
||
| @cli.group() | ||
| @pass_dev | ||
| # @click.argument('command', required=False) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (107 > 100 characters)