Add nightly toolchain to commands #172
Conversation
This flag skips:
adding target
compiling to wasm
installing wasm-bindgen
running wasm-bindgen
src/build.rs
Outdated
| @@ -11,10 +11,30 @@ pub fn rustup_add_wasm_target() -> Result<(), Error> { | |||
| emoji::TARGET | |||
| ); | |||
| let pb = PBAR.message(&step); | |||
| let nightly_check = Command::new("rustc").arg("+nightly").arg("-V").output()?; | |||
There was a problem hiding this comment.
This whole part should be it's own section/fn as there's no sub bar really. It should just be part of the process.
There was a problem hiding this comment.
Just pushed an update with this change
src/build.rs
Outdated
| @@ -11,10 +11,30 @@ pub fn rustup_add_wasm_target() -> Result<(), Error> { | |||
| emoji::TARGET | |||
| ); | |||
| let pb = PBAR.message(&step); | |||
| let nightly_check = Command::new("rustc").arg("+nightly").arg("-V").output()?; | |||
| if !nightly_check.status.success() { | |||
| let sub_bar = PBAR.message(&format!( | |||
There was a problem hiding this comment.
There's another PR where this is going to change a little so be prepared to rebase!
Specifically here:
https://github.com/ashleygwilliams/wasm-pack/pull/151
You'll need to add this function to the vec that way it knows to call it and how to calculate how many steps there are etc.
There was a problem hiding this comment.
Let me know when I need to perform the rebase
|
hey! thanks so much for this- i think this is great, and mostly echo @mgattozzi 's comments re: rebasing, particularly from #151 which i think we intend to land first- if you could rebase this off of that i think it'd be great to try and get this into today's release. if you're not up for that- don't worry, we can also do it for you- but i always like to ask if folks would like to do it themselves :) |
|
oh also- would you mind fixing up into a single commit message? thanks so much! |
FreeMasen
force-pushed
the
master
branch
2 times, most recently
from
7b8a55f
to
acd8fe8
Compare
|
This should be 1 commit and it was re-based against the 151 branch |
|
thank you so much!! |
|
closed by #175 ! thanks so much!! |
To address issue #171
This change will check if
rustc +nightly -Vreturns an error, if it does it will runrustup toolchain add nightly. It then updated the previous process to run the following.rustup target add wasm32-unknown-unknown --toolchain nightlycargo +nightly build --target wasm32-unknown-unknownThis should make things a little bit easier for new rust users
Make sure these boxes are checked! 📦✅
rustfmtinstalled and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightlyrustfmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨