Add --skip-build flag for init command #144

[kohensu]

pull request for #144

[ashleygwilliams]

hey! i've given this a first pass and tbh i think it's really fantastic- awesome job! i have a few comments, but one is a style nit and the other is potentially something to implement at a later date. i want to pull this down and run it (not cuz i don't trust you, but because i don't trust our tests)... but in general i think this is gonna be good to merge very soon!

[ashleygwilliams]

would like a line here :)

[kohensu]

oups,
yes sure

[ashleygwilliams]

(ugh GH didn't post this comment in my original review)

so- i think we might be exploring even more "build" modes (see #153 ) - so (and i am likely overengineering here) but perhaps an enum and a match statement would work best here. would love to hear your thoughts!

[kohensu]

Do you mean something like this ?

enum InitMode {
    Normal,
    Nobuild,
}

impl Init {
    pub fn process(&mut self, log: &Logger, mode: InitMode) -> result::Result<(), Error> {
        let steps: Vec<fn(&mut Init, &Step, &Logger) -> result::Result<(), Error>> =
            match mode {
                InitMode::Normal => vec![
                    Init::step_add_wasm_target,
                    ...
                ],
                InitMode::Nobuild => vec![
                    Init::step_create_dir,
                    ...
                ],
            };
        let mut step = Step::new(steps.len());
        ...
    }
}

pub fn run_wasm_pack(command: Command, log: &Logger) -> result::Result<(), Error> {
    let status = match command {
        Command::Init {
            path,
            scope,
            skip_build,
            disable_dts,
            target,
        } => {
            ...
            let mode = if skip_build {InitMode::Nobuild} else {InitMode::Normal};
            Init::new(path, scope, disable_dts, target).process(&log, mode)
        }
        ...
    };
    ...
}

[kohensu]

I did the modification this modification in the PR, if it is not like you what you had in mind I will revert it.

[mgattozzi]

I never thought to make it a vector of functions. Honestly this is just a real clever PR and I really like it. My own nit is I don't think we need to rename every function to step_* but that's more of a personal preference and I'll defer to @ashleygwilliams on this! Seriously well done. Gonna have to test this out locally as well! :D

[ashleygwilliams]

@kohensu super impressed with this- thanks so much! the only thing this needs is a test and some docs (a paragraph like the other flags in this doc: https://github.com/ashleygwilliams/wasm-pack/blob/master/docs/init.md). lemme know if you wanna do that or if you'd like some help!

[ashleygwilliams]

also- just as a heads up we are probably landing 2 PRs today which means this will likely need a rebase, but i'd like to prioritize getting this in after that so that we don't have too much rebasing that needs to happen :)

[ashleygwilliams]

lemme know if you want to tackle the rebase- otherwise i can do it!

[kohensu]

ok, I will do the rebase, the test and the doc

[mgattozzi]

Just wanted to say that this LGTM :) great job!