Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nightly toolchain to commands #171

Closed
FreeMasen opened this issue Jun 12, 2018 · 2 comments · Fixed by #175
Closed

Add nightly toolchain to commands #171

FreeMasen opened this issue Jun 12, 2018 · 2 comments · Fixed by #175
Labels
good first issue Good for newcomers help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx
Milestone
0.4.0

Comments

@FreeMasen
Copy link

Currently, unless the user has set cargo to use the nightly compiler, this project will fail in a somewhat unfriendly way.

Updating the rustup/cargo commands to account for this would be helpful.

rustup target add wasm32-unknown-unknown --toolchain nightly
cargo +nightly build --target wasm32-unknown-unknown

It may be helpful to check that the nightly toolchain is actually installed as well
rustc +nightly -V or similar.
@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx labels Jun 12, 2018
@ashleygwilliams
Copy link
Member

@FreeMasen this is an excellent suggestion! if you'd like to add it- we'd welcome a PR- otherwise i'll open this up to contributors!

@ashleygwilliams ashleygwilliams added this to the 0.4.0 milestone Jun 12, 2018
@ashleygwilliams ashleygwilliams added the good first issue Good for newcomers label Jun 12, 2018
@FreeMasen
Copy link
Author

I should be able to knock that out tomorrow.

@FreeMasen FreeMasen mentioned this issue Jun 13, 2018
Closed
This was referenced Jun 13, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Add nightly toolchain to commands rustwasm/wasm-pack
2 participants
@ashleygwilliams @FreeMasen