Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[must_use] to is_condition tests #89797

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jkugelman
Copy link
Contributor

I threw in std::path::Path::has_root for funsies.

A continuation of #89718.

Parent issue: #89692

r? @joshtriplett

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2021
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 12, 2021
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 12, 2021

📌 Commit 01b439e has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2021
…ts, r=joshtriplett

Add #[must_use] to is_condition tests

I threw in `std::path::Path::has_root` for funsies.

A continuation of rust-lang#89718.

Parent issue: rust-lang#89692

r? `@joshtriplett`
the8472 added a commit to the8472/rust that referenced this pull request Oct 12, 2021
…ts, r=joshtriplett

Add #[must_use] to is_condition tests

I threw in `std::path::Path::has_root` for funsies.

A continuation of rust-lang#89718.

Parent issue: rust-lang#89692

r? ``@joshtriplett``
This was referenced Oct 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2021
Rollup of 7 pull requests

Successful merges:

 - rust-lang#89778 (Add #[must_use] to as_type conversions)
 - rust-lang#89784 (Remove built-in query cache_hit tracking)
 - rust-lang#89796 (Add #[must_use] to non-mutating verb methods)
 - rust-lang#89797 (Add #[must_use] to is_condition tests)
 - rust-lang#89799 (fix minor spelling error in Poll::ready docs)
 - rust-lang#89800 (Update books)
 - rust-lang#89809 (Remap ssa RealPredicate to llvm RealPredicate)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4cf0f1f into rust-lang:master Oct 12, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 12, 2021
@jkugelman jkugelman deleted the must-use-is_condition-tests branch October 12, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants