Add #[must_use] to as_type conversions #89778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Actually jeez, I just grepped by hand and there are another 69 |
joshtriplett
added
the
relnotes
|
@bors r+ |
|
📌 Commit 06e625f has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 11, 2021
…ons, r=joshtriplett Add #[must_use] to as_type conversions Clippy missed these: ```rust alloc::string::String fn as_mut_str(&mut self) -> &mut str; core::mem::NonNull<T> unsafe fn as_uninit_mut<'a>(&mut self) -> &'a MaybeUninit<T>; str unsafe fn as_bytes_mut(&mut self) -> &mut [u8]; str fn as_mut_ptr(&mut self) -> *mut u8; ``` Parent issue: rust-lang#89692 r? `@joshtriplett`
the8472
added
the
T-libs
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2021
…ons, r=joshtriplett Add #[must_use] to as_type conversions Clippy missed these: ```rust alloc::string::String fn as_mut_str(&mut self) -> &mut str; core::mem::NonNull<T> unsafe fn as_uninit_mut<'a>(&mut self) -> &'a MaybeUninit<T>; str unsafe fn as_bytes_mut(&mut self) -> &mut [u8]; str fn as_mut_ptr(&mut self) -> *mut u8; ``` Parent issue: rust-lang#89692 r? ``@joshtriplett``
the8472
added a commit
to the8472/rust
that referenced
this pull request
Oct 12, 2021
…ons, r=joshtriplett Add #[must_use] to as_type conversions Clippy missed these: ```rust alloc::string::String fn as_mut_str(&mut self) -> &mut str; core::mem::NonNull<T> unsafe fn as_uninit_mut<'a>(&mut self) -> &'a MaybeUninit<T>; str unsafe fn as_bytes_mut(&mut self) -> &mut [u8]; str fn as_mut_ptr(&mut self) -> *mut u8; ``` Parent issue: rust-lang#89692 r? ```@joshtriplett```
This was referenced Oct 12, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#89778 (Add #[must_use] to as_type conversions) - rust-lang#89784 (Remove built-in query cache_hit tracking) - rust-lang#89796 (Add #[must_use] to non-mutating verb methods) - rust-lang#89797 (Add #[must_use] to is_condition tests) - rust-lang#89799 (fix minor spelling error in Poll::ready docs) - rust-lang#89800 (Update books) - rust-lang#89809 (Remap ssa RealPredicate to llvm RealPredicate) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy missed these:
Parent issue: #89692
r? @joshtriplett