Remove built-in query cache_hit tracking #89784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
delete-cache-hit-tracking
branch
from
ee66d32
to
a02a920
Compare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
delete-cache-hit-tracking
branch
from
a02a920
to
b521e13
Compare
This comment has been minimized.
This comment has been minimized.
|
r=me with green CI. cc @wesleywiser as the reviewer of #57118 which added this statistic. |
petrochenkov
added
S-waiting-on-author
This was already only enabled in debug_assertions builds. Generally, it seems like most use cases that would use this could also use the -Zself-profile flag which also tracks cache hits (in all builds), and so the extra cfg's and such are not really necessary. This is largely just a small cleanup though, which primarily is intended to make other changes easier by avoiding the need to deal with this field.
Mark-Simulacrum
force-pushed
the
delete-cache-hit-tracking
branch
from
b521e13
to
1273738
Compare
|
@bors r=petrochenkov |
|
📌 Commit 1273738 has been approved by |
bors
added
S-waiting-on-bors
the8472
added a commit
to the8472/rust
that referenced
this pull request
Oct 12, 2021
…acking, r=petrochenkov Remove built-in query cache_hit tracking This was already only enabled in debug_assertions builds. Generally, it seems like most use cases that would use this could also use the -Zself-profile flag which also tracks cache hits (in all builds), and so the extra cfg's and such are not really necessary. This is largely just a small cleanup though, which primarily is intended to make other changes easier by avoiding the need to deal with this field.
This was referenced Oct 12, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#89778 (Add #[must_use] to as_type conversions) - rust-lang#89784 (Remove built-in query cache_hit tracking) - rust-lang#89796 (Add #[must_use] to non-mutating verb methods) - rust-lang#89797 (Add #[must_use] to is_condition tests) - rust-lang#89799 (fix minor spelling error in Poll::ready docs) - rust-lang#89800 (Update books) - rust-lang#89809 (Remap ssa RealPredicate to llvm RealPredicate) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already only enabled in debug_assertions builds. Generally, it seems
like most use cases that would use this could also use the -Zself-profile flag
which also tracks cache hits (in all builds), and so the extra cfg's and such
are not really necessary.
This is largely just a small cleanup though, which primarily is intended to make
other changes easier by avoiding the need to deal with this field.