-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 19 pull requests #81013
Rollup of 19 pull requests #81013
Commits on Dec 4, 2020
-
Update tests of "unused_lifetimes" lint for async functions and corre…
…sponding source code
Dmitry Murygin committedDec 4, 2020 Configuration menu - View commit details
-
Copy full SHA for 64f11b9 - Browse repository at this point
Copy the full SHA 64f11b9View commit details
Commits on Dec 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3ea744e - Browse repository at this point
Copy the full SHA 3ea744eView commit details
Commits on Dec 20, 2020
-
Add a
std::io::read_to_string
functionThe equivalent of `std::fs::read_to_string`, but generalized to all `Read` impls. As the documentation on `std::io::read_to_string` says, the advantage of this function is that it means you don't have to create a variable first and it provides more type safety since you can only get the buffer out if there were no errors. If you use `Read::read_to_string`, you have to remember to check whether the read succeeded because otherwise your buffer will be empty. It's friendlier to newcomers and better in most cases to use an explicit return value instead of an out parameter.
Configuration menu - View commit details
-
Copy full SHA for 1f9a8a1 - Browse repository at this point
Copy the full SHA 1f9a8a1View commit details
Commits on Dec 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4ee6d1b - Browse repository at this point
Copy the full SHA 4ee6d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 588786a - Browse repository at this point
Copy the full SHA 588786aView commit details
Commits on Dec 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7ed824e - Browse repository at this point
Copy the full SHA 7ed824eView commit details
Commits on Jan 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7a0ada0 - Browse repository at this point
Copy the full SHA 7a0ada0View commit details
Commits on Jan 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f7d261c - Browse repository at this point
Copy the full SHA f7d261cView commit details
Commits on Jan 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ebe402d - Browse repository at this point
Copy the full SHA ebe402dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9ef798 - Browse repository at this point
Copy the full SHA a9ef798View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cb8303 - Browse repository at this point
Copy the full SHA 5cb8303View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6c07b0 - Browse repository at this point
Copy the full SHA e6c07b0View commit details
Commits on Jan 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7463292 - Browse repository at this point
Copy the full SHA 7463292View commit details
Commits on Jan 13, 2021
-
Suggest
_
and..
if a pattern has too few fieldsFor example, this code: struct S(i32, f32); let S(x) = S(0, 1.0); will make the compiler suggest either: let S(x, _) = S(0, 1.0); or: let S(x, ..) = S(0, 1.0);
Configuration menu - View commit details
-
Copy full SHA for 16692ab - Browse repository at this point
Copy the full SHA 16692abView commit details -
Co-authored-by: Esteban Kuber <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5fe61a7 - Browse repository at this point
Copy the full SHA 5fe61a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d9df5 - Browse repository at this point
Copy the full SHA f3d9df5View commit details -
Pluralize 'parenthesis' correctly
It's 'parentheses', not 'parenthesis', when you have more than one.
Configuration menu - View commit details
-
Copy full SHA for a5e8e6e - Browse repository at this point
Copy the full SHA a5e8e6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe82cc3 - Browse repository at this point
Copy the full SHA fe82cc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9959d6d - Browse repository at this point
Copy the full SHA 9959d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bce775 - Browse repository at this point
Copy the full SHA 1bce775View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7307a7 - Browse repository at this point
Copy the full SHA d7307a7View commit details -
Use better ICE message when no MIR is available
The ICE message is somewhat confusing and overly specific - the issue is that there's no MIR available. This should make debugging these ICEs easier since the error tells you what's actually wrong, not what it was trying to do when it failed. cc rust-lang#80952 (comment)
Configuration menu - View commit details
-
Copy full SHA for c3f7429 - Browse repository at this point
Copy the full SHA c3f7429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e83fec - Browse repository at this point
Copy the full SHA 7e83fecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bfd987 - Browse repository at this point
Copy the full SHA 6bfd987View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8c8793 - Browse repository at this point
Copy the full SHA e8c8793View commit details -
Configuration menu - View commit details
-
Copy full SHA for d65cb6e - Browse repository at this point
Copy the full SHA d65cb6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 697b20f - Browse repository at this point
Copy the full SHA 697b20fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52adfdd - Browse repository at this point
Copy the full SHA 52adfddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c1b0d - Browse repository at this point
Copy the full SHA 64c1b0dView commit details -
unix ExitStatus: Do not treat WIFSTOPPED as WIFSIGNALED
A unix wait status can contain, at least, exit statuses, termination signals, and stop signals. WTERMSIG is only valid if WIFSIGNALED. https://pubs.opengroup.org/onlinepubs/9699919799/functions/wait.html It will not be easy to experience this bug with `Command`, because that doesn't pass WUNTRACED. But you could make an ExitStatus containing, say, a WIFSTOPPED, from a call to one of the libc wait functions. (In the WIFSTOPPED case, there is WSTOPSIG. But a stop signal is encoded differently to a termination signal, so WTERMSIG and WSTOPSIG are by no means the same.) Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5b1316f - Browse repository at this point
Copy the full SHA 5b1316fView commit details -
unix ExitStatus: Clarify docs for .signal()
We need to be clear that this never returns WSTOPSIG. That is, if WIFSTOPPED, the return value is None. Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 12d62aa - Browse repository at this point
Copy the full SHA 12d62aaView commit details -
unix ExitStatus: Provide .into_raw()
Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 530270f - Browse repository at this point
Copy the full SHA 530270fView commit details -
unix ExitStatus: Provide .core_dumped
This is essential for proper reporting of child process status on Unix. Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f05051 - Browse repository at this point
Copy the full SHA 3f05051View commit details -
unix ExitStatus: Provide .stopped_signal()
Necessary to handle WIFSTOPPED. Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f060b9e - Browse repository at this point
Copy the full SHA f060b9eView commit details -
unix ExitStatus: Provide .continued()
Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42ea8f6 - Browse repository at this point
Copy the full SHA 42ea8f6View commit details -
Replace
Ie
withIn other words
Co-authored-by: Joshua Nelson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 29c851a - Browse repository at this point
Copy the full SHA 29c851aView commit details -
Replace
Ie
withIn other words
Co-authored-by: Joshua Nelson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 06a405c - Browse repository at this point
Copy the full SHA 06a405cView commit details -
unix ExitStatus: Add tracking issue to new methods
Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fa68567 - Browse repository at this point
Copy the full SHA fa68567View commit details -
ExitStatusExt unix: Retrospectively seal this trait
As discussed in rust-lang#79982. I think the "new interfaces", ie the new trait and impl, must be insta-stable. This seems OK because we are, in fact, adding a new restriction to the stable API. Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7012194 - Browse repository at this point
Copy the full SHA 7012194View commit details -
ExitStatusExt windows: Retrospectively seal this trait
Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3e7199 - Browse repository at this point
Copy the full SHA f3e7199View commit details -
Configuration menu - View commit details
-
Copy full SHA for efddf59 - Browse repository at this point
Copy the full SHA efddf59View commit details -
ExitStatusExt: Fix build on Fuchsia
This is not particularly pretty but the current situation is a mess and I don't think I'm making it significantly worse. Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 05a88aa - Browse repository at this point
Copy the full SHA 05a88aaView commit details -
Fix stabilisation version of slice_strip
See rust-lang#77853 (review) Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b59fa3d - Browse repository at this point
Copy the full SHA b59fa3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9528988 - Browse repository at this point
Copy the full SHA 9528988View commit details -
Remove the unused context from CreateDebugLocation
This went unused in commit 88d874d, part of rust-lang#68965.
Configuration menu - View commit details
-
Copy full SHA for 0342fd1 - Browse repository at this point
Copy the full SHA 0342fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 391b4cc - Browse repository at this point
Copy the full SHA 391b4ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b2f085 - Browse repository at this point
Copy the full SHA 9b2f085View commit details
Commits on Jan 14, 2021
-
Add as_ref and as_mut methods for Bound
Add as_ref and as_mut method for std::ops::range::Bound, patterned off of the methods of the same name on Option.
Configuration menu - View commit details
-
Copy full SHA for eb72dc5 - Browse repository at this point
Copy the full SHA eb72dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8d0161 - Browse repository at this point
Copy the full SHA a8d0161View commit details -
Rollup merge of rust-lang#79689 - Vooblin:patch1, r=tmandry
Update tests of "unused_lifetimes" lint for async functions and corresponding source code Before this PR the following code would cause an error: ``` #![deny(unused_lifetimes)] async fn f<'a>(_: &'a i32) {} fn main() {} ``` It was happening because of the desugaring of return type in async functions. As a result of the desugaring, the return type contains all lifetimes involved in the function signature. And these lifetimes were interpreted separately from the same in the function scope => so they are unused. Now, all lifetimes from the return type are interpreted as used. It is also not perfect, but at least this lint doesn't cause wrong errors now. This PR connected to issues rust-lang#78522, rust-lang#77217
Configuration menu - View commit details
-
Copy full SHA for 05f5db4 - Browse repository at this point
Copy the full SHA 05f5db4View commit details -
Rollup merge of rust-lang#79982 - ijackson:exit-status, r=dtolnay
Add missing methods to unix ExitStatusExt These are the methods corresponding to the remaining exit status examination macros from `wait.h`. `WCOREDUMP` isn't in SuS but is it is very standard. I have not done portability testing to see if this builds everywhere, so I may need to Do Something if it doesn't. There is also a bugfix and doc improvement to `.signal()`, and an `.into_raw()` accessor. This would fix rust-lang#73128 and fix rust-lang#73129. Please let me know if you like this direction, and if so I will open the tracking issue and so on. If this MR goes well, I may tackle rust-lang#73125 next - I have an idea for how to do it.
Configuration menu - View commit details
-
Copy full SHA for aacb26d - Browse repository at this point
Copy the full SHA aacb26dView commit details -
Rollup merge of rust-lang#80017 - camelid:sugg-rest-pattern, r=estebank
Suggest `_` and `..` if a pattern has too few fields Fixes rust-lang#80010.
Configuration menu - View commit details
-
Copy full SHA for b07415c - Browse repository at this point
Copy the full SHA b07415cView commit details -
Rollup merge of rust-lang#80169 - frewsxcv:frewsxcv-docs-fix, r=jyn514
Recommend panic::resume_unwind instead of panicking. Fixes rust-lang#79950.
Configuration menu - View commit details
-
Copy full SHA for 473c292 - Browse repository at this point
Copy the full SHA 473c292View commit details -
Rollup merge of rust-lang#80217 - camelid:io-read_to_string, r=m-ou-se
Add a `std::io::read_to_string` function I recognize that you're usually supposed to open an issue first, but the implementation is very small so it's okay if this is closed and it was 'wasted work' :) ----- The equivalent of `std::fs::read_to_string`, but generalized to all `Read` impls. As the documentation on `std::io::read_to_string` says, the advantage of this function is that it means you don't have to create a variable first and it provides more type safety since you can only get the buffer out if there were no errors. If you use `Read::read_to_string`, you have to remember to check whether the read succeeded because otherwise your buffer will be empty. It's friendlier to newcomers and better in most cases to use an explicit return value instead of an out parameter.
Configuration menu - View commit details
-
Copy full SHA for 35833c2 - Browse repository at this point
Copy the full SHA 35833c2View commit details -
Rollup merge of rust-lang#80444 - glittershark:bound-as-ref, r=dtolnay
Add as_ref and as_mut methods for Bound Add as_ref and as_mut method for std::ops::range::Bound, patterned off of the methods of the same name on Option. I'm not quite sure what the process is for introducing new feature gates (this is my first contribution) so I've left these ungated, but happy to do whatever is necessary to gate them.
Configuration menu - View commit details
-
Copy full SHA for 4ac831b - Browse repository at this point
Copy the full SHA 4ac831bView commit details -
Rollup merge of rust-lang#80567 - lukaslueg:intersperse_with, r=m-ou-se
Add Iterator::intersperse_with This is a follow-up to rust-lang#79479, tracking in rust-lang#79524, as discussed rust-lang#79479 (comment). ~~Note that I had to manually implement `Clone` and `Debug` because `derive` insists on placing a `Clone`-bound on the struct-definition, which is too narrow. There is a long-standing issue # for this somewhere around here :-)~~ Also, note that I refactored the guts of `Intersperse` into private functions and re-used them in `IntersperseWith`, so I also went light on duplicating all the tests. If this is suitable to be merged, the tracking issue should be updated, since it only mentions `intersperse`. Happy New Year! r? `@m-ou-se`
Configuration menu - View commit details
-
Copy full SHA for 7c4d34f - Browse repository at this point
Copy the full SHA 7c4d34fView commit details -
Rollup merge of rust-lang#80829 - jyn514:dep-constructor, r=michaelwo…
…erister Get rid of `DepConstructor` This removes fully 235 unused functions. Follow-up to rust-lang#80325 (comment). r? `@michaelwoerister` cc `@cjgillot`
Configuration menu - View commit details
-
Copy full SHA for 4913b50 - Browse repository at this point
Copy the full SHA 4913b50View commit details -
Rollup merge of rust-lang#80895 - sfackler:read-to-end-ub, r=m-ou-se
Fix handling of malicious Readers in read_to_end A malicious `Read` impl could return overly large values from `read`, which would result in the guard's drop impl setting the buffer's length to greater than its capacity! ~~To fix this, the drop impl now uses the safe `truncate` function instead of `set_len` which ensures that this will not happen. The result of calling the function will be nonsensical, but that's fine given the contract violation of the `Read` impl.~~ ~~The `Guard` type is also used by `append_to_string` which does not pass untrusted values into the length field, so I've copied the guard type into each function and only modified the one used by `read_to_end`. We could just keep a single one and modify it, but it seems a bit cleaner to keep the guard code close to the functions and related specifically to them.~~ To fix this, we now assert that the returned length is not larger than the buffer passed to the method. For reference, this bug has been present for ~2.5 years since 1.20: rust-lang@ecbb896. Closes rust-lang#80894.
Configuration menu - View commit details
-
Copy full SHA for 09276b0 - Browse repository at this point
Copy the full SHA 09276b0View commit details -
Rollup merge of rust-lang#80944 - LingMan:map_or, r=nagisa
Use Option::map_or instead of `.map(..).unwrap_or(..)` ````@rustbot```` modify labels +C-cleanup +T-compiler
Configuration menu - View commit details
-
Copy full SHA for c0c379a - Browse repository at this point
Copy the full SHA c0c379aView commit details -
Rollup merge of rust-lang#80966 - KodrAus:deprecate/spin_loop_hint, r…
…=m-ou-se Deprecate atomic::spin_loop_hint in favour of hint::spin_loop For rust-lang#55002 We wanted to leave `atomic::spin_loop_hint` alone when stabilizing `hint::spin_loop` so folks had some time to migrate. This now deprecates `atomic_spin_loop_hint`.
Configuration menu - View commit details
-
Copy full SHA for de47f47 - Browse repository at this point
Copy the full SHA de47f47View commit details -
Rollup merge of rust-lang#80969 - camelid:monomorph-ice-msg, r=nagisa
Use better ICE message when no MIR is available The ICE message is somewhat confusing and overly specific - the issue is that there's no MIR available. This should make debugging these ICEs easier since the error tells you what's actually wrong, not what it was trying to do when it failed. cc rust-lang#80952 (comment) cc ````@jyn514````
Configuration menu - View commit details
-
Copy full SHA for b480d2b - Browse repository at this point
Copy the full SHA b480d2bView commit details -
Rollup merge of rust-lang#80972 - KodrAus:deprecate/remove_item, r=na…
…gisa Remove unstable deprecated Vec::remove_item Closes rust-lang#40062 The `Vec::remove_item` method was deprecated in `1.46.0` (in August of 2020). This PR now removes that unstable method entirely.
Configuration menu - View commit details
-
Copy full SHA for b18bbf5 - Browse repository at this point
Copy the full SHA b18bbf5View commit details -
Rollup merge of rust-lang#80973 - ehuss:update-books, r=ehuss
Update books ## nomicon 2 commits in a5a48441d411f61556b57d762b03d6874afe575d..a8584998eacdea7106a1dfafcbf6c1c06fcdf925 2020-12-06 10:39:41 +0900 to 2021-01-06 12:49:49 -0500 - Update vector code examples - Remove outdated information about `jemalloc` ## reference 13 commits in b278478b766178491a8b6f67afa4bcd6b64d977a..50af691f838937c300b47812d0507c6d88c14f97 2020-12-21 18:18:03 -0800 to 2021-01-12 21:19:20 -0800 - Update grammar for parser unification. (rust-lang/reference#927) - Define constraining an implementation (rust-lang/reference#928) - Document extra behavior of #[no_mangle] (rust-lang/reference#930) - Add a float examle without a `.`. (rust-lang/reference#929) - Add more details about const generics. (rust-lang/reference#921) - Fix footnotes. (rust-lang/reference#926) - Add "Logic errors" as behavior not considered unsafe (rust-lang/reference#919) - Update grammar for order of parameters/arguments. (rust-lang/reference#920) - Fix formatting in the tuple section (rust-lang/reference#923) - document const generics (rust-lang/reference#901) - Update mdbook (rust-lang/reference#918) - linkage.md: update link to FFI section of the Book. (rust-lang/reference#917) - Document array expression with a const. (rust-lang/reference#914) ## book 8 commits in 5bb44f8b5b0aa105c8b22602e9b18800484afa21..ac57a0ddd23d173b26731ccf939f3ba729753275 2020-12-18 20:07:31 -0500 to 2021-01-09 14:18:45 -0500 - Update version of mdbook we're testing with to 0.4.5 (rust-lang/book#2561) - Fix grammar in ch13-01-closures.md (rust-lang/book#2534) - Merge remote-tracking branch 'origin/pr/2527' - Clarify code example ch6.3 (rust-lang/book#2485) - Fix link added in rust-lang/book#2495 to be relative and at the bottom - Merge remote-tracking branch 'origin/pr/2495' - Update output to match the updated poem punctuation - Fix rust-lang/book#2539 - Remove fancy apostrophes from poem for Windows ## rust-by-example 3 commits in 1cce0737d6a7d3ceafb139b4a206861fb1dcb2ab..03e23af01f0b4f83a3a513da280e1ca92587f2ec 2020-12-21 17:36:29 -0300 to 2021-01-09 10:20:28 -0300 - Replace for loop with iteration (rust-lang/rust-by-example#1404) - Update mdbook (rust-lang/rust-by-example#1402) - Add note for match guards to include catch-all (rust-lang/rust-by-example#1401) ## embedded-book 1 commits in ba34b8a968f9531d38c4dc4411d5568b7c076bfe..ceec19e873be87c6ee5666b030c6bb612f889a96 2020-11-17 00:20:43 +0000 to 2021-01-03 13:13:10 +0000 - book.toml: add link to GitHub repo (rust-embedded/book#276)
Configuration menu - View commit details
-
Copy full SHA for 4e5eb81 - Browse repository at this point
Copy the full SHA 4e5eb81View commit details -
Rollup merge of rust-lang#80980 - trevarj:patch-1, r=nagisa
Fixed incorrect doc comment ">" is right alignment, not left
Configuration menu - View commit details
-
Copy full SHA for e4f75cc - Browse repository at this point
Copy the full SHA e4f75ccView commit details -
Rollup merge of rust-lang#80981 - bjorn3:bjorn3-patch-1, r=jonas-schi…
…evink Fix -Cpasses=list and llvm version print with -vV cc rust-lang#77975 (comment)
Configuration menu - View commit details
-
Copy full SHA for 459b274 - Browse repository at this point
Copy the full SHA 459b274View commit details -
Rollup merge of rust-lang#80985 - ijackson:slice-strip-fix, r=jyn514
Fix stabilisation version of slice_strip See rust-lang#77853 (review) Signed-off-by: Ian Jackson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4dc3a44 - Browse repository at this point
Copy the full SHA 4dc3a44View commit details -
Rollup merge of rust-lang#80990 - cuviper:unused-debug-context, r=nagisa
llvm: Remove the unused context from CreateDebugLocation This went unused in commit 88d874d, part of rust-lang#68965.
Configuration menu - View commit details
-
Copy full SHA for 896757f - Browse repository at this point
Copy the full SHA 896757fView commit details -
Rollup merge of rust-lang#80991 - calebsander:fix/fmt-link, r=m-ou-se
Fix formatting specifiers doc links d36e3e2 seems to have inadvertently changed many of these links to point to `core::fmt` instead of `std::fmt`. The information about formatting specifiers is only documented in [`std::fmt`](https://doc.rust-lang.org/std/fmt/); [`core::fmt`](https://doc.rust-lang.org/core/fmt/) is empty. 3baf6a4 seems to have already fixed a couple of these links to point back to `std::fmt`.
Configuration menu - View commit details
-
Copy full SHA for ce19d93 - Browse repository at this point
Copy the full SHA ce19d93View commit details