Recommend panic::resume_unwind instead of panicking. #80169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Comment on lines
-1192
to
+1193
| /// match on the `Err` variant and handle the panic in an appropriate way. | ||
| /// match on the `Err` variant and handle the panic in an appropriate way |
There was a problem hiding this comment.
Why remove the period? It's a complete sentence even though it is formatted with an enumeration.
There was a problem hiding this comment.
The statement on its own is not a complete sentence
Comment on lines
+1199
to
+1200
| /// Matching on the result of a joined thread: | ||
| /// |
There was a problem hiding this comment.
This seems to mean that the example is going to show case (2) above. However, the example below is changed from case (2) to case (1). Which one is correct/intended? Or should there be two examples?
There was a problem hiding this comment.
Previously it was just demonstrating matching. Now it is demonstrating matching and the panic_unwind.
frewsxcv
added
the
A-docs
|
@bors r+ rollup |
|
📌 Commit 3ea744e has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 14, 2021
Recommend panic::resume_unwind instead of panicking. Fixes rust-lang#79950.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 14, 2021
Recommend panic::resume_unwind instead of panicking. Fixes rust-lang#79950.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 14, 2021
Recommend panic::resume_unwind instead of panicking. Fixes rust-lang#79950.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 14, 2021
Recommend panic::resume_unwind instead of panicking. Fixes rust-lang#79950.
This was referenced Jan 14, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2021
Rollup of 17 pull requests Successful merges: - rust-lang#79982 (Add missing methods to unix ExitStatusExt) - rust-lang#80017 (Suggest `_` and `..` if a pattern has too few fields) - rust-lang#80169 (Recommend panic::resume_unwind instead of panicking.) - rust-lang#80217 (Add a `std::io::read_to_string` function) - rust-lang#80444 (Add as_ref and as_mut methods for Bound) - rust-lang#80567 (Add Iterator::intersperse_with) - rust-lang#80829 (Get rid of `DepConstructor`) - rust-lang#80895 (Fix handling of malicious Readers in read_to_end) - rust-lang#80966 (Deprecate atomic::spin_loop_hint in favour of hint::spin_loop) - rust-lang#80969 (Use better ICE message when no MIR is available) - rust-lang#80972 (Remove unstable deprecated Vec::remove_item) - rust-lang#80973 (Update books) - rust-lang#80980 (Fixed incorrect doc comment) - rust-lang#80981 (Fix -Cpasses=list and llvm version print with -vV) - rust-lang#80985 (Fix stabilisation version of slice_strip) - rust-lang#80990 (llvm: Remove the unused context from CreateDebugLocation) - rust-lang#80991 (Fix formatting specifiers doc links) Failed merges: - rust-lang#80944 (Use Option::map_or instead of `.map(..).unwrap_or(..)`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79950.