Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linker-plugin-lto.md to contain up to rust 1.46 #76402

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Sep 6, 2020

Hi,
this is the same as #72290, if anyone has suggestions on how to automate this please say :)
otherwise, you can check the versions I've added via:

$ rustup install 1.44.0
$ rustc +1.44.0 -Vv
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-unknown-linux-gnu
release: 1.44.0
LLVM version: 9.0

$ rustup install 1.45.0
$ rustc +1.45.0 -Vv
rustc 1.45.0 (5c1f21c3b 2020-07-13)
binary: rustc
commit-hash: 5c1f21c3b82297671ad3ae1e8c942d2ca92e84f2
commit-date: 2020-07-13
host: x86_64-unknown-linux-gnu
release: 1.45.0
LLVM version: 10.0

$ rustup install 1.46.0
$ rustc +stable -Vv
rustc 1.46.0 (04488afe3 2020-08-24)
binary: rustc
commit-hash: 04488afe34512aa4c33566eb16d8c912a3ae04f9
commit-date: 2020-08-24
host: x86_64-unknown-linux-gnu
release: 1.46.0
LLVM version: 10.0

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2020
@GuillaumeGomez
Copy link
Member

r? @wesleywiser

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like every Rust version is only ever compatible with one Clang version, so perhaps we should change the table from an m*n matrix to a simple list of compatible versions?

@elichai
Copy link
Contributor Author

elichai commented Sep 6, 2020

It looks like every Rust version is only ever compatible with one Clang version, so perhaps we should change the table from an m*n matrix to a simple list of compatible versions?

Agreed, I just thought about the fact that soon(current nightly) it will require Clang 11, so I'll replace this with something like this:

Rust version Clang Version
Rust 1.34 Clang 7
Rust 1.35 Clang 8
Rust 1.36 Clang 9

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 6, 2020

📌 Commit 2e82589 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 7, 2020

if anyone has suggestions on how to automate this please say

@elichai You can automate the checking, not sure about editing the docs.

rustup toolchain install --profile minimal nightly
MINOR_VERSION=$(rustc +nightly --version | cut -d . -f 2)
LOWER_BOUND=44

llvm_version() {
    toolchain="$1"
    printf "Rust $toolchain    |    Clang "
    rustc +"$toolchain" -Vv | grep LLVM | cut -d ':' -f 2 | tr -d ' '
}

for version in `seq $LOWER_BOUND $((MINOR_VERSION - 2))`; do
    toolchain=1.$version.0
    rustup toolchain install --no-self-update --profile  minimal $toolchain >/dev/null 2>&1
    llvm_version $toolchain
done

for toolchain in beta nightly; do
    rustup toolchain install --no-self-update --profile minimal $toolchain >/dev/null 2>&1
    llvm_version $toolchain
done

Example output:

Rust 1.44.0    |    Clang 9.0
Rust 1.45.0    |    Clang 10.0
Rust 1.46.0    |    Clang 10.0
Rust beta    |    Clang 11.0
Rust nightly    |    Clang 11.0

beta/nightly is a little off, but I've spent enough time on this 😅

@jyn514 jyn514 added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Sep 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 7, 2020
Update linker-plugin-lto.md to contain up to rust 1.46

Hi,
this is the same as rust-lang#72290, if anyone has suggestions on how to automate this please say :)
otherwise, you can check the versions I've added via:

```sh
$ rustup install 1.44.0
$ rustc +1.44.0 -Vv
rustc 1.44.0 (49cae55 2020-06-01)
binary: rustc
commit-hash: 49cae55
commit-date: 2020-06-01
host: x86_64-unknown-linux-gnu
release: 1.44.0
LLVM version: 9.0

$ rustup install 1.45.0
$ rustc +1.45.0 -Vv
rustc 1.45.0 (5c1f21c 2020-07-13)
binary: rustc
commit-hash: 5c1f21c
commit-date: 2020-07-13
host: x86_64-unknown-linux-gnu
release: 1.45.0
LLVM version: 10.0

$ rustup install 1.46.0
$ rustc +stable -Vv
rustc 1.46.0 (04488af 2020-08-24)
binary: rustc
commit-hash: 04488af
commit-date: 2020-08-24
host: x86_64-unknown-linux-gnu
release: 1.46.0
LLVM version: 10.0
```
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#76162 (Make duration_since documentation more clear)
 - rust-lang#76355 (remove public visibility previously needed for rustfmt)
 - rust-lang#76374 (Improve ayu doc source line number contrast)
 - rust-lang#76379 (rustbuild: Remove `Mode::Codegen`)
 - rust-lang#76389 (Fix HashMap visualizers in Visual Studio (Code))
 - rust-lang#76396 (Fix typo in tracking issue template)
 - rust-lang#76401 (Add help note to unconstrained const parameter)
 - rust-lang#76402 (Update linker-plugin-lto.md to contain up to rust 1.46)
 - rust-lang#76403 (Fix documentation for TyCtxt::all_impls)
 - rust-lang#76498 (Update cargo)

Failed merges:

 - rust-lang#76458 (Add drain_filter method to HashMap and HashSet)

r? `@ghost`
@bors bors merged commit 1aef86c into rust-lang:master Sep 9, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 9, 2020
@elichai elichai deleted the patch-2 branch September 9, 2020 11:22
tmandry added a commit to tmandry/rust that referenced this pull request Sep 9, 2020
Add a script to automatically update Rust/Clang versions in documentation

From rust-lang#76402 (comment).

r? @elichai
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants