Fix HashMap visualizers in Visual Studio (Code)

[MaulingMonkey]

CDB (as used in unit tests) doesn't care that we're using static_cast between unrelated types (u8* to tuple<$T1, $T2>*).
Visual Studio & Visual Studio Code care. These should've been reinterpret_cast or C casts.

Credit to @petrochenkov per #76352 for helping catch this.

Testing

x.py test --stage 1 src/tools/tidy
x.py test --stage 1 --build x86_64-pc-windows-msvc src\test\debuginfo

[rust-highfive]

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

[petrochenkov]

r? @petrochenkov @bors r+ rollup

This fixes an issue introduced in #70052, so it needs a beta backport, if I'm counting correctly.

[bors]

📌 Commit 5acd272 has been approved by petrochenkov

[bors]

⌛ Testing commit 5acd272 with merge a44b3feeb49707093c85f9a85dea92b5dbcdc130...

[rust-log-analyzer]

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Build completed successfully in 0:01:55
+ /scripts/validate-toolstate.sh
Cloning into 'rust-toolstate'...
<Nothing changed>
HTTPError: HTTP Error 403: Forbidden
b'{"message":"API rate limit exceeded for user ID 7378925.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}'
Traceback (most recent call last):
  File "../../src/tools/publish_toolstate.py", line 288, in <module>
    validate_maintainers(repo, github_token)
  File "../../src/tools/publish_toolstate.py", line 84, in validate_maintainers
    'Accept': 'application/vnd.github.hellcat-preview+json',
  File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden
  local time: Mon Sep  7 09:15:11 UTC 2020
  network time: Mon, 07 Sep 2020 09:15:11 GMT
== end clock drift check ==
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (5770) (node)
Terminate orphan process: pid (5779) (python)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

[bors]

💔 Test failed - checks-actions

[petrochenkov]

2020-09-07T09:15:11.6377660Z HTTPError: HTTP Error 403: Forbidden
2020-09-07T09:15:11.6379339Z b'{"message":"API rate limit exceeded for user ID 7378925.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}'

@bors retry

[spastorino]

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted