Improve ayu doc source line number contrast #76374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve contrast of foreground line number.
LeSeulArtichaut
added
the
S-waiting-on-review
jyn514
added
A-rustdoc-themes
|
Looks good to me, thank you! 😄 (I don't think I have any bors perms? so someone else will need to r+ this) I agree the line would look nice on the other themes as well, if other people feel the same it would be nice to add that. |
|
@bors r=Cldfire |
|
📌 Commit d80415a has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
|
⌛ Testing commit d80415a with merge 78e663278763336735fcbcc87af971a313df37b4... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 7, 2020
Improve ayu doc source line number contrast Improve contrast of foreground line number. Before  After  r? @Cldfire I think we should add the line for light and dark theme too, it looks better and clearer that way.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#76162 (Make duration_since documentation more clear) - rust-lang#76355 (remove public visibility previously needed for rustfmt) - rust-lang#76374 (Improve ayu doc source line number contrast) - rust-lang#76379 (rustbuild: Remove `Mode::Codegen`) - rust-lang#76389 (Fix HashMap visualizers in Visual Studio (Code)) - rust-lang#76396 (Fix typo in tracking issue template) - rust-lang#76401 (Add help note to unconstrained const parameter) - rust-lang#76402 (Update linker-plugin-lto.md to contain up to rust 1.46) - rust-lang#76403 (Fix documentation for TyCtxt::all_impls) - rust-lang#76498 (Update cargo) Failed merges: - rust-lang#76458 (Add drain_filter method to HashMap and HashSet) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve contrast of foreground line number.
Before
After
r? @Cldfire
I think we should add the line for light and dark theme too, it looks better and clearer that way.