Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #70483

Merged
merged 10 commits into from
Mar 28, 2020
Merged

Rollup of 5 pull requests #70483

merged 10 commits into from
Mar 28, 2020

Commits on Mar 27, 2020

  1. Remove no_integrated_as mode. 

    Specifically, remove both `-Z no_integrated_as` and
`TargetOptions::no_integrated_as`. The latter was only used for the
`msp430_none_elf` platform, for which it's no longer required.
    @nnethercote
    nnethercote committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    02840ca View commit details
    Browse the repository at this point in the history

  2. non-exhastive diagnostic: add note re. scrutinee type

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c858593 View commit details
    Browse the repository at this point in the history

  3. suggest semi on expr mac!() good as stmt mac!().

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    6c643a0 View commit details
    Browse the repository at this point in the history

  4. clarify hir_id <-> node_id method names

    @lcnr
    lcnr committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    37603f4 View commit details
    Browse the repository at this point in the history

  5. refactor type_of for consts

    @lcnr
    lcnr committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c339b2e View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#70345 - nnethercote:rm-no_integrated_as, r=… 

    …alexcrichton

Remove `no_integrated_as` mode.

Specifically, remove both `-Z no_integrated_as` and
`TargetOptions::no_integrated_as`. The latter was only used for the
`msp430_none_elf` platform, for which it's no longer required.

r? @alexcrichton
    @Centril
    Centril authored Mar 27, 2020
    Configuration menu
    Copy the full SHA
    08e867c View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#70434 - Centril:fix-34421, r=estebank 

    suggest `;` on expr `mac!()` which is good as stmt `mac!()`

Fixes rust-lang#34421 by implementing @jseyfried's suggestion in rust-lang#34421 (comment).

r? @petrochenkov
    @Centril
    Centril authored Mar 27, 2020
    Configuration menu
    Copy the full SHA
    cfe1e33 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#70457 - Centril:non-exhaustive-scrutinee-ty… 

    …pe, r=estebank

non-exhastive diagnostic: add note re. scrutinee type

This fixes rust-lang#67259 by adding a note:
```
    = note: the matched value is of type &[i32]
```
to non-exhaustive pattern matching errors.

r? @varkor @estebank
    @Centril
    Centril authored Mar 27, 2020
    Configuration menu
    Copy the full SHA
    23d3fa2 View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#70478 - lcnr:refactor-type_of, r=varkor 

    Refactor type_of for constants

If I have to look at this function for a few hours I want it to at least look good.

r? @varkor
    @Centril
    Centril authored Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5b68f9c View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#70480 - lcnr:appayupyup, r=eddyb 

    clarify hir_id <-> node_id method names

resolves 2 FIXME.

r? @eddyb
    @Centril
    Centril authored Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a023e61 View commit details
    Browse the repository at this point in the history